Handle the case where an incomplete set of AWS credentials were provided.

Author: iclanton

rush-plugins/rush-amazon-s3-build-cache-plugin/src/AmazonS3Credentials.ts

@@ -32,9 +32,19 @@ export const fromAmazonEnv = (): IAmazonS3Credentials | undefined => {
       secretAccessKey,
       sessionToken
     };
+  } else if (accessKeyId) {
+    throw new Error(
+      `The "${AWS_ACCESS_KEY_ID}" env variable is set, but the "${AWS_SECRET_ACCESS_KEY}" `+
+      `env variable is not set. Both or neither must be provided.`
+    );
+  } else if (secretAccessKey) {
+    throw new Error(
+      `The "${AWS_SECRET_ACCESS_KEY}" env variable is set, but the "${AWS_ACCESS_KEY_ID}" `+
+      `env variable is not set. Both or neither must be provided.`
+    );
+  } else {
+    return undefined;
   }
-
-  return undefined;
 };
 
 /**

rush-plugins/rush-amazon-s3-build-cache-plugin/src/test/AmazonS3Credentials.test.ts

@@ -20,6 +20,10 @@ describe('Amazon S3 Credentials', () => {
       oldEnvAwsAccessKeyId = process.env[AWS_ACCESS_KEY_ID];
       oldEnvAwsSecretAccessKey = process.env[AWS_SECRET_ACCESS_KEY];
       oldEnvAwsSessionToken = process.env[AWS_SESSION_TOKEN];
+      
+      delete process.env[AWS_ACCESS_KEY_ID];
+      delete process.env[AWS_SECRET_ACCESS_KEY];
+      delete process.env[AWS_SESSION_TOKEN];
     });
 
     afterEach(() => {
@@ -55,10 +59,11 @@ describe('Amazon S3 Credentials', () => {
 
     it('returns undefined if access key and secret are not both present', () => {
       process.env[AWS_ACCESS_KEY_ID] = AWS_ACCESS_KEY_ID;
+      expect(() => fromAmazonEnv()).toThrowErrorMatchingSnapshot();
 
-      const credentials = fromAmazonEnv();
-
-      expect(credentials).toBeUndefined();
+      delete process.env[AWS_ACCESS_KEY_ID];
+      process.env[AWS_SECRET_ACCESS_KEY] = AWS_SECRET_ACCESS_KEY;
+      expect(() => fromAmazonEnv()).toThrowErrorMatchingSnapshot();
     });
   });