DOC: set canonical #22716
Merged
DOC: set canonical #22716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works as expected on CI: https://67489-1385122-gh.circle-artifacts.com/0/doc/build/html/index.html. |
|
Should we put this behind the same release flag that we use for GA etc? |
|
We could, but I don't think it means anything for unpublished sites. I guess the dev branch but we still want canonical to point to stable. And if the canonical doesn't exist (new page) then I think google just picks up the real page anyway. |
|
I'm thinking about distros that want to build the docs for offline use etc. I guess it does little harm, but it is worth trying to be tidy. I'm going to approve this, but leave it to @QuLogic to merge. |
tacaswell
approved these changes
Mar 28, 2022
QuLogic
approved these changes
Mar 29, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 29, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 29, 2022
oscargus
added a commit
that referenced
this pull request
Mar 29, 2022
…716-on-v3.5.1-doc Backport PR #22716 on branch v3.5.1-doc (DOC: set canonical)
oscargus
added a commit
that referenced
this pull request
Mar 29, 2022
…716-on-v3.5.x Backport PR #22716 on branch v3.5.x (DOC: set canonical)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This closes matplotlib/matplotlib.github.com#68 going forward, though it doesn't go back and fix 3.5 and 3.5.1
3.5.0 and 3.5.1 do not list the canonical links as
/stable/index.html(etc) and google has started surfacing/3.5.1/index.htmlas the canonical and ignoring/stable/index.htmlas a duplicate. We wantstableto be the canonical, so this adds:<link rel="canonical" href="https://matplotlib.org/stable/index.html" />toindex.htmlor<link rel="canonical" href="https://matplotlib.org/stable/gallery/frontpage/3D.html" />togallery/frontpage/3D.htmletc.PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).