Refactor error handling a little

Signed-off-by: Eric Wang <[email protected]>

Author: skygragon

lib/leetcode_client.js

@@ -16,12 +16,26 @@ function makeOpts(url) {
   return opts;
 }
 
+function checkError(e, resp, expectedStatus, msg) {
+  if (e) return e;
+
+  if (resp && resp.statusCode !== expectedStatus) {
+    if (resp.statusCode === 403)
+      msg = msg || 'session expired, please login again';
+
+    return {
+      msg:        msg || 'http error',
+      statusCode: resp.statusCode
+    };
+  }
+}
+
 var leetcodeClient = {};
 
 leetcodeClient.getProblems = function(cb) {
   request(makeOpts(config.PROBLEMS_URL), function(e, resp, body) {
+    e = checkError(e, resp, 200);
     if (e) return cb(e);
-    if (resp.statusCode !== 200) return cb('HTTP failed:' + resp.statusCode);
 
     var problems = JSON.parse(body).stat_status_pairs.map(function(p) {
       return {
@@ -49,8 +63,8 @@ var aceCtrl = {
 
 leetcodeClient.getProblem = function(problem, cb) {
   request(problem.link, function(e, resp, body) {
+    e = checkError(e, resp, 200);
     if (e) return cb(e);
-    if (resp.statusCode !== 200) return cb('HTTP failed:' + resp.statusCode);
 
     var $ = cheerio.load(body);
     var info = $('div[class="question-info text-info"] ul li strong');
@@ -74,8 +88,8 @@ leetcodeClient.getProblem = function(problem, cb) {
 
 leetcodeClient.login = function(user, cb) {
   request(config.LOGIN_URL, function(e, resp, body) {
+    e = checkError(e, resp, 200);
     if (e) return cb(e);
-    if (resp.statusCode !== 200) return cb('HTTP failed:' + resp.statusCode);
 
     user.loginCSRF = h.getSetCookieValue(resp, 'csrftoken');
 
@@ -93,8 +107,8 @@ leetcodeClient.login = function(user, cb) {
       }
     };
     request.post(opts, function(e, resp, body) {
+      e = checkError(e, resp, 302, 'invalid password?');
       if (e) return cb(e);
-      if (resp.statusCode !== 302) return cb('HTTP failed:' + resp.statusCode);
 
       user.sessionCSRF = h.getSetCookieValue(resp, 'csrftoken');
       user.sessionId = h.getSetCookieValue(resp, 'PHPSESSID');
@@ -112,8 +126,8 @@ function verifyResult(opts, jobs, results, cb) {
 
   opts.url = config.VERIFY_URL.replace('$id', jobs[0].id);
   request.get(opts, function(e, resp, body) {
+    e = checkError(e, resp, 200);
     if (e) return cb(e);
-    if (resp.statusCode !== 200) return cb('HTTP failed:' + resp.statusCode);
 
     var result = JSON.parse(body);
     if (result.state === 'SUCCESS') {
@@ -142,8 +156,8 @@ leetcodeClient.testProblem = function(problem, cb) {
   };
 
   request.post(opts, function(e, resp, body) {
+    e = checkError(e, resp, 200);
     if (e) return cb(e);
-    if (resp.statusCode !== 200) return cb('HTTP failed:' + resp.statusCode);
 
     opts.json = false;
     opts.body = null;
@@ -172,8 +186,8 @@ leetcodeClient.submitProblem = function(problem, cb) {
   };
 
   request.post(opts, function(e, resp, body) {
+    e = checkError(e, resp, 200);
     if (e) return cb(e);
-    if (resp.statusCode !== 200) return cb('HTTP failed:' + resp.statusCode);
 
     opts.json = false;
     opts.body = null;