Refactor: remove duplicate code to get user name.

Signed-off-by: Eric Wang <[email protected]>

Author: skygragon

Diff for: lib/plugins/leetcode.js

@@ -391,8 +391,7 @@ plugin.signin = function(user, cb) {
 
       user.sessionCSRF = h.getSetCookieValue(resp, 'csrftoken');
       user.sessionId = h.getSetCookieValue(resp, 'LEETCODE_SESSION');
-      user.name = h.getSetCookieValue(resp, 'messages')
-                   .match('Successfully signed in as ([^.]*)')[1];
+      session.saveUser(user);
       return cb(null, user);
     });
   });
@@ -407,7 +406,7 @@ plugin.getUser = function(user, cb) {
     });
     user.hash = favorite.id_hash;
     user.name = favorites.user_name;
-
+    session.saveUser(user);
     return cb(null, user);
   });
 };
@@ -416,7 +415,6 @@ plugin.login = function(user, cb) {
   log.debug('running leetcode.login');
   plugin.signin(user, function(e, user) {
     if (e) return cb(e);
-    session.saveUser(user);
     plugin.getUser(user, cb);
   });
 };

Diff for: test/plugins/test_leetcode.js

@@ -53,8 +53,7 @@ describe('plugin:leetcode', function() {
         .reply(302, '', {
           'Set-Cookie': [
             'csrftoken=SESSION_CSRF_TOKEN; Max-Age=31449600; Path=/; secure',
-            'LEETCODE_SESSION=SESSION_ID; Max-Age=31449600; Path=/; secure',
-            "messages='Successfully signed in as Eric.'; Max-Age=31449600; Path=/; secure"
+            'LEETCODE_SESSION=SESSION_ID; Max-Age=31449600; Path=/; secure'
           ]});
 
       nock('https://leetcode.com')