Use builtin functions.

* Array.prototype.forEach
* Array.prototype.filter
* Array.prototype.find
* Array.prototype.map
* Array.prototype.some
* Array.isArray
* Number.isNaN
* String.prototype.includes

Signed-off-by: Eric Wang <[email protected]>

Author: skygragon

Diff for: lib/chalk.js

@@ -53,7 +53,7 @@ chalk.wrap = function(pre, post) {
 function bgName(s) { return 'bg' + s[0].toUpperCase() + s.substr(1); }
 
 chalk.init = function() {
-  _.each(require('./helper').getCodeDirData('colors'), function(f) {
+  require('./helper').getCodeDirData('colors').forEach(function(f) {
     var o = {};
     _.pairs(f.data).forEach(function(x) {
       var k = x[0];

Diff for: lib/commands/cache.js

@@ -42,7 +42,7 @@ cmd.handler = function(argv) {
   } else {
     _.sortBy(caches, function(f) {
       var x = parseInt(f.name.split('.')[0], 10);
-      if (_.isNaN(x)) x = 0;
+      if (Number.isNaN(x)) x = 0;
       return x;
     })
     .forEach(function(f) {

Diff for: lib/commands/list.js

@@ -51,8 +51,8 @@ cmd.handler = function(argv) {
       if (word.endsWith(word.substr(-1).repeat(6))) {
         log.warn('Hmmm...you might need a new keyboard?');
       }
-      problems = _.filter(problems, function(x) {
-        return x.name.toLowerCase().indexOf(word) >= 0;
+      problems = problems.filter(function(x) {
+        return x.name.toLowerCase().includes(word);
       });
     }
 

Diff for: lib/commands/show.js

@@ -88,7 +88,7 @@ function showProblem(problem, argv) {
   var code;
   var needcode = argv.gen || argv.codeonly;
   if (needcode) {
-    var template = _.find(problem.templates, function(x) {
+    var template = problem.templates.find(function(x) {
       return x.value === argv.lang;
     });
     if (!template) {
@@ -166,14 +166,14 @@ cmd.handler = function(argv) {
 
       // random select one that not AC-ed yet
       var user = session.getUser();
-      problems = _.filter(problems, function(x) {
+      problems = problems.filter(function(x) {
         if (x.state === 'ac') return false;
         if (!user.paid && x.locked) return false;
         return true;
       });
       if (problems.length === 0) return cb('Problem not found!');
 
-      var problem = problems[_.random(problems.length - 1)];
+      var problem = _.sample(problems);
       core.getProblem(problem, function(e, problem) {
         if (e) return log.fail(e);
         showProblem(problem, argv);

Diff for: lib/commands/stat.js

@@ -109,7 +109,7 @@ function showGraph(problems) {
   log.info('    ' + header);
 
   var graph = [];
-  _.each(problems, function(problem) {
+  problems.forEach(function(problem) {
     graph[problem.id] = ICONS[problem.state] || ICONS.none;
   });
 
@@ -214,7 +214,7 @@ cmd.handler = function(argv) {
     if (e) return log.fail(e);
 
     if (!argv.lock)
-      problems = _.reject(problems, function(x) { return x.locked; });
+      problems = problems.filter(function(x) { return !x.locked; });
 
     log.info();
     if (argv.graph)    showGraph(problems);

Diff for: lib/commands/submission.js

@@ -1,6 +1,5 @@
 var fs = require('fs');
 
-var _ = require('underscore');
 var sprintf = require('sprintf-js').sprintf;
 
 var h = require('../helper');
@@ -81,14 +80,14 @@ function exportSubmission(problem, argv, cb) {
       return cb('No submissions?');
 
     // get obj list contain required filetype
-    submissions = _.filter(submissions, function(x) {
+    submissions = submissions.filter(function(x) {
       return argv.lang === 'all' || argv.lang === x.lang;
     });
     if (submissions.length === 0)
       return cb('No submissions in required language.');
 
     // if no accepted, use the latest non-accepted one
-    var submission = _.find(submissions, function(x) {
+    var submission = submissions.find(function(x) {
       return x.status_display === 'Accepted';
     }) || submissions[0];
     submission.ac = (submission.status_display === 'Accepted');

Diff for: lib/commands/submit.js

@@ -28,7 +28,7 @@ function printResult(actual, k) {
   if (!actual.hasOwnProperty(k)) return;
 
   var v = actual[k] || '';
-  var lines = _.isArray(v) ? v : [v];
+  var lines = Array.isArray(v) ? v : [v];
   lines.forEach(function(line) {
     if (k !== 'state') line = k + ': ' + line;
     log.info('  ' + h.prettyText(' ' + line, actual.ok));

Diff for: lib/commands/test.js

@@ -44,7 +44,7 @@ function printResult(actual, expect, k) {
   var ok = actual.ok;
   if (expect && !_.isEqual(actual[k], expect[k])) ok = false;
 
-  var lines = _.isArray(v) ? v : [v];
+  var lines = Array.isArray(v) ? v : [v];
   lines.forEach(function(line) {
     if (k !== 'state') line = k + ': ' + line;
     log.info('  ' + h.prettyText(' ' + line, ok));

Diff for: lib/commands/version.js

@@ -70,7 +70,7 @@ cmd.handler = function(argv) {
   printLine('Icons', _.keys(icon.themes));
 
   log.info('\n[Plugins]');
-  _.each(Plugin.plugins, function(p, k) {
+  Plugin.plugins.forEach(function(p, k) {
     printLine(p.name, p.ver);
   });
 };

Diff for: lib/core.js

@@ -34,8 +34,8 @@ core.filters = {
 };
 
 function hasTag(o, tag) {
-  return _.isArray(o) &&
-    _.some(o, function(x) { return x.indexOf(tag.toLowerCase()) >= 0; });
+  return Array.isArray(o) &&
+    o.some(function(x) { return x.indexOf(tag.toLowerCase()) >= 0; });
 }
 
 function isLevel(x, q) { return x.level[0].toLowerCase() === q.toLowerCase(); }
@@ -65,11 +65,11 @@ core.filterProblems = function(opts, cb) {
     (opts.query || '').split('').forEach(function(q) {
       var f = QUERY_HANDLERS[q];
       if (!f) return;
-      problems = _.filter(problems, function(x) { return f(x, q); });
+      problems = problems.filter(function(x) { return f(x, q); });
     });
 
     (opts.tag || []).forEach(function(t) {
-      problems = _.filter(problems, function(x) {
+      problems = problems.filter(function(x) {
         return x.category === t ||
           hasTag(x.companies, t) ||
           hasTag(x.tags, t);
@@ -88,7 +88,7 @@ core.getProblem = function(keyword, cb) {
     if (e) return cb(e);
 
     keyword = Number(keyword) || keyword;
-    var problem = _.find(problems, function(x) {
+    var problem = problems.find(function(x) {
       return x.id === keyword || x.name === keyword || x.slug === keyword;
     });
     if (!problem) return cb('Problem not found!');

Diff for: lib/helper.js

@@ -123,7 +123,7 @@ h.statusToName = function(sc) {
 };
 
 h.langToExt = function(lang) {
-  var res = _.find(LANGS, function(x) { return x.lang === lang; });
+  var res = LANGS.find(function(x) { return x.lang === lang; });
   return res ? res.ext : '.raw';
 };
 
@@ -139,7 +139,7 @@ h.extToLang = function(fullpath) {
 };
 
 h.langToCommentStyle = function(lang) {
-  var res = _.find(LANGS, function(x) { return x.lang === lang; });
+  var res = LANGS.find(function(x) { return x.lang === lang; });
 
   return (res && res.style === '#') ?
   {start: '#',  line: '#',  end: '#'} :
@@ -153,7 +153,7 @@ h.mkdir = function(fullpath) {
 
 h.getCodeDirData = function(dir) {
   dir = h.getCodeDir(dir);
-  return _.map(fs.readdirSync(dir), function(file) {
+  return fs.readdirSync(dir).map(function(file) {
     var fullpath = path.join(dir, file);
     var ext = path.extname(file);
 

Diff for: lib/icon.js

@@ -20,7 +20,7 @@ icons.setTheme = function(name) {
 };
 
 icons.init = function() {
-  _.each(h.getCodeDirData('icons'), function(f) {
+  h.getCodeDirData('icons').forEach(function(f) {
     icons.themes[f.name] = f.data;
   });
 };

Diff for: lib/plugin.js

@@ -18,7 +18,7 @@ function Plugin(id, name, ver, desc, deps) {
 
   // only need deps for current platform
   this.deps = _.chain(deps || [])
-    .filter(function(x) { return x.indexOf(':') < 0 || x.indexOf(':' + process.platform) > 0; })
+    .filter(function(x) { return ! x.includes(':') || x.includes(':' + process.platform); })
     .map(function(x) { return x.split(':')[0]; })
     .value();
 }

Diff for: lib/plugins/cache.js

@@ -57,7 +57,7 @@ plugin.updateProblem = function(problem, kv) {
   var problems = cache.get(h.KEYS.problems);
   if (!problems) return false;
 
-  var _problem = _.find(problems, function(x) { return x.id === problem.id; });
+  var _problem = problems.find(function(x) { return x.id === problem.id; });
   if (!_problem) return false;
 
   _.extend(_problem, kv);

Diff for: lib/plugins/leetcode.js

@@ -189,7 +189,7 @@ function runCode(opts, problem, cb) {
     if (e) return cb(e);
 
     if (body.error) {
-      if (body.error.indexOf('too soon') < 0)
+      if (!body.error.includes('too soon'))
         return cb(body.error);
 
       // hit 'run code too soon' error, have to wait a bit
@@ -312,7 +312,7 @@ plugin.getSubmissions = function(problem, cb) {
 
     // FIXME: this only return the 1st 20 submissions, we should get next if necessary.
     var submissions = JSON.parse(body).submissions_dump;
-    _.each(submissions, function(submission) {
+    submissions.forEach(function(submission) {
       submission.id = _.last(_.compact(submission.url.split('/')));
     });
 
@@ -419,7 +419,7 @@ plugin.getUser = function(user, cb) {
   plugin.getFavorites(function(e, favorites) {
     if (e) return cb(e);
 
-    var favorite = _.find(favorites.favorites.private_favorites, function(f) {
+    var favorite = favorites.favorites.private_favorites.find(function(f) {
       return f.name === 'Favorite';
     });
     user.hash = favorite.id_hash;

Diff for: templates/detailed.tpl

@@ -9,6 +9,6 @@
 <%= comment.line %> Total Submissions: <%= totalSubmit %>
 <%= comment.line %> Testcase Example:  <%= testcase %>
 <%= comment.line %>
-<% _.each(desc, function(x) { %><%= comment.line %> <%= x %>
+<% desc.forEach(function(x) { %><%= comment.line %> <%= x %>
 <% }) %><%= comment.end %>
 <%= code %>