[refactor] use file utils.

Signed-off-by: Eric Wang <[email protected]>

Author: skygragon

lib/cache.js

@@ -1,5 +1,4 @@
 'use strict';
-var fs = require('fs');
 var path = require('path');
 
 var file = require('./file');
@@ -12,22 +11,22 @@ cache.init = function() {
 
 cache.get = function(k) {
   const fullpath = file.cacheFile(k);
-  if (!fs.existsSync(fullpath)) return null;
+  if (!file.exist(fullpath)) return null;
 
-  return JSON.parse(fs.readFileSync(fullpath));
+  return JSON.parse(file.data(fullpath));
 };
 
 cache.set = function(k, v) {
   const fullpath = file.cacheFile(k);
-  fs.writeFileSync(fullpath, JSON.stringify(v));
+  file.write(fullpath, JSON.stringify(v));
   return true;
 };
 
 cache.del = function(k) {
   const fullpath = file.cacheFile(k);
-  if (!fs.existsSync(fullpath)) return false;
+  if (!file.exist(fullpath)) return false;
 
-  fs.unlinkSync(fullpath);
+  file.rm(fullpath);
   return true;
 };
 
@@ -36,7 +35,7 @@ cache.list = function() {
     .filter(x => path.extname(x) === '.json')
     .map(function(filename) {
       const k = path.basename(filename, '.json');
-      const stat = fs.statSync(file.cacheFile(k));
+      const stat = file.stat(file.cacheFile(k));
       return {
         name:  k,
         size:  stat.size,

lib/commands/config.js

@@ -55,7 +55,7 @@ function loadConfig(showall) {
 }
 
 function saveConfig() {
-  require('fs').writeFileSync(file.configFile(), prettyConfig(loadConfig(false)));
+  file.write(file.configFile(), prettyConfig(loadConfig(false)));
 }
 
 cmd.handler = function(argv) {

lib/commands/show.js

@@ -1,5 +1,4 @@
 'use strict';
-var fs = require('fs');
 var util = require('util');
 
 var _ = require('underscore');
@@ -84,7 +83,7 @@ function genFileName(problem, opts) {
   // try new name to avoid overwrite by mistake
   for (let i = 0; ; ++i) {
     const name = path.join(opts.outdir, params.join('.').replace(/\.+/g, '.'));
-    if (!fs.existsSync(name))
+    if (!file.exist(name))
       return name;
     params[2] = i;
   }
@@ -123,7 +122,7 @@ function showProblem(problem, argv) {
   if (argv.gen) {
     file.mkdir(argv.outdir);
     filename = genFileName(problem, argv);
-    fs.writeFileSync(filename, code);
+    file.write(filename, code);
 
     if (argv.editor !== undefined) {
       childProcess.spawn(argv.editor || config.code.editor, [filename], {

lib/commands/submission.js

@@ -1,5 +1,4 @@
 'use strict';
-var fs = require('fs');
 var path = require('path');
 
 var _ = require('underscore');
@@ -102,7 +101,7 @@ function exportSubmission(problem, argv, cb) {
 
     file.mkdir(argv.outdir);
     // skip the existing cached submissions
-    if (fs.existsSync(f))
+    if (file.exist(f))
       return cb(null, chalk.underline(f));
 
     core.getSubmission(submission, function(e, submission) {
@@ -113,7 +112,7 @@ function exportSubmission(problem, argv, cb) {
         code: submission.code,
         tpl:  argv.extra ? 'detailed' : 'codeonly'
       };
-      fs.writeFileSync(f, core.exportProblem(problem, opts));
+      file.write(f, core.exportProblem(problem, opts));
       cb(null, submission.ac ? chalk.green.underline(f)
                              : chalk.yellow.underline(f));
     });

lib/commands/submit.js

@@ -1,5 +1,4 @@
 'use strict';
-var fs = require('fs');
 var util = require('util');
 
 var h = require('../helper');
@@ -44,7 +43,7 @@ function printLine() {
 
 cmd.handler = function(argv) {
   session.argv = argv;
-  if (!fs.existsSync(argv.filename))
+  if (!file.exist(argv.filename))
     return log.error('File ' + argv.filename + ' not exist!');
 
   const meta = file.meta(argv.filename);

lib/commands/test.js

@@ -1,5 +1,4 @@
 'use strict';
-var fs = require('fs');
 var _ = require('underscore');
 
 var h = require('../helper');
@@ -54,7 +53,7 @@ function printResult(actual, expect, k) {
 }
 
 function runTest(argv) {
-  if (!fs.existsSync(argv.filename))
+  if (!file.exist(argv.filename))
     return log.error('File ' + argv.filename + ' not exist!');
 
   const meta = file.meta(argv.filename);

lib/file.js

@@ -75,9 +75,29 @@ file.mkdir = function(fullpath) {
   mkdirp.sync(fullpath);
 };
 
+file.exist = function(fullpath) {
+  return fs.existsSync(fullpath);
+};
+
+file.rm = function(fullpath) {
+  return fs.unlinkSync(fullpath);
+};
+
+file.mv = function(src, dst) {
+  return fs.renameSync(src, dst);
+};
+
 file.list = function(dir) {
   return fs.readdirSync(dir);
-}
+};
+
+file.stat = function(fullpath) {
+  return fs.statSync(fullpath);
+};
+
+file.write = function(fullpath, data) {
+  return fs.writeFileSync(fullpath, data);
+};
 
 file.name = function(fullpath) {
   return path.basename(fullpath, path.extname(fullpath));

lib/plugin.js

@@ -49,7 +49,7 @@ Plugin.prototype.enable = function(enabled) {
   if (this.enabled === enabled) return;
   const newfile = enabled ? this.file.substr(1) : '.' + this.file;
   try {
-    fs.renameSync(file.pluginFile(this.file), file.pluginFile(newfile));
+    file.mv(file.pluginFile(this.file), file.pluginFile(newfile));
   } catch(e) {
     log.error(e.message);
   }
@@ -60,7 +60,7 @@ Plugin.prototype.delete = function() {
   if (!this.missing) {
     try {
       const fullpath = file.pluginFile(this.file);
-      fs.unlinkSync(fullpath);
+      file.rm(fullpath);
     } catch(e) {
       return log.error(e.message);
     }
@@ -156,7 +156,7 @@ Plugin.copy = function(src, cb) {
   });
   srcstream.on('error', function(e) {
     spin.stop();
-    fs.unlinkSync(dst);
+    file.rm(dst);
     return cb(e);
   });