[10.x] DB::raw remove backticks and add them to table.column

[mfaas89]

Issue:

The exception I got was: "SQLSTATE[H093] Invalid parameter number (Connection: mysq, select ...)". There where no reserved keywords.

The query builder throws errors in some cases where backticks are not used on raw queries on execution.
If you execute the dumped query by sentry it will execute in mysql.

Products:

• Mysql 8
• php8.3
• laravel 10

Solution:

Enforce backticks on raw expressions.
Remove all backticks and add them where the combination of table and column are used.

$value = 'ROUND(cs`.credit)';

var_dump( preg_replace(
	'/(\w+)[.](\w+)+/',
	'`$1`.`$2`',
	str_replace('`', '', $value)
));

public function wrap($value, $prefixAlias = false)
    {
        if ($this->isExpression($value)) {
            return $this->wrapRaw(
                (string) $this->getValue($value)
            );
        }

        .....
    }

public function wrapRaw(string $value): string
    {
        return preg_replace(
            '/(\w+)[.](\w+)+/',
            '`$1`.`$2`',
            str_replace('`', '', $this->getValue($value))
        );
    }

The exception I got was: "SQLSTATE[H093] Invalid parameter number (Connection: mysq, select ...)". There where no reserved keywords.

I created a pull request here #54813

I probably need to fix the styling and tests, but I would like to know if this is something that can be added?

[macropay-solutions]

$value = 'ROUND(cs`.credit)';

So you want to avoid typos with this?

What if the column name is a reserved word?

[mfaas89]

Typos is on of the issues, but not the reason I made it.

I did no check for reserved names, I will have a look at that, thank you!

In my case I had some issues with select raw combined with left join raw queries.
If the raw query prefixed with tables did not contain backticks it would throw an exception, but with the backticks it worked without issue.
This is why I wanted to enforce the backticks.

I will add the exception from my work later.

I can't share the queries unfortunately.

[mfaas89]

The exception I got was: "SQLSTATE[H093] Invalid parameter number (Connection: mysq, select ...)". There where no reserved keywords.

It did not have any reserved words inside it. When I used the query from sentry it still executed in mysql, but it did not when trying to use the eloquent get() method.
When I changed the tables to use backticks it worked.

[macropay-solutions]

If you remove the ticks,and your table has a reserved word as column like select, where etc it will not work.

[mfaas89]

I get what you mean. I can just remove the str_replace. This way it will only add backticks to tables and columns missing backticks