Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KDS v1 #9075

Closed
lahabana opened this issue Jan 30, 2024 · 2 comments
Closed

Remove KDS v1 #9075

lahabana opened this issue Jan 30, 2024 · 2 comments
Assignees
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone

Comments

@lahabana
Copy link
Contributor

What happened?

It's been default for 2 versions! Remove in 2.7 🥳

@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/cleanup Cleanup/refactor an existing component/code labels Jan 30, 2024
@lahabana lahabana added this to the 2.7.x milestone Jan 30, 2024
bartsmykla pushed a commit that referenced this issue Jan 31, 2024
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Feb 5, 2024
@lahabana lahabana modified the milestones: 2.7.x, 2.8.x Mar 27, 2024
@lobkovilya
Copy link
Contributor

When cleaning up make sure we're not depending on specific types anymore when syncing resources, i.e. ZoneIngress/ZoneEgress in ZoneTag func:

func ZoneTag(r model.Resource) string {
switch res := r.GetSpec().(type) {
case *mesh_proto.Dataplane:
if res.GetNetworking().GetGateway() != nil {
return res.GetNetworking().GetGateway().GetTags()[mesh_proto.ZoneTag]
}
return res.GetNetworking().GetInbound()[0].GetTags()[mesh_proto.ZoneTag]
case *mesh_proto.ZoneIngress:
return res.GetZone()
case *mesh_proto.ZoneEgress:
return res.GetZone()
default:
return ""
}
}

Functions like GlobalProvidedFilter/ZoneProvidedFilter and GlobalSyncCallback/ZoneSyncCallback should depend only on KDSFlags

@lahabana lahabana modified the milestones: 2.8.x, 2.9.x Jun 3, 2024
@Icarus9913
Copy link
Contributor

on me

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

5 participants