Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usages of patrickmn/go-cache with a better cache #1919

Closed
lahabana opened this issue Apr 30, 2021 · 10 comments
Closed

Replace usages of patrickmn/go-cache with a better cache #1919

lahabana opened this issue Apr 30, 2021 · 10 comments
Labels
kind/improvement Improvement on an existing feature triage/rotten closed due to lack of information for too long, rejected feature...

Comments

@lahabana
Copy link
Contributor

lahabana commented Apr 30, 2021 •
edited
Loading

patrickmn/go-cache has several issues:

  • Doesn't have a bounded size
  • Doesn't support much concurrency (only uses 1 shard mutex)
  • Doesn't support async loading
  • Doesn't have stats

We use this library 4 times:

  • pkg/core/resource/manager/cache.go
  • pkg/plugins/resources/k8s/caching_converter.go
  • pkg/xds/cache/once/cache.go

We have these problems in all 3 places and have written work-arounds for them.

goburrow/cache is an implementation that has all these features.
It might be worth replacing these usages.

Other option is https://github.com/allegro/bigcache which seems to be used a lot and is maintained
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Nov 23, 2021
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@lahabana lahabana added triage/rotten closed due to lack of information for too long, rejected feature... and removed triage/stale Inactive for some time. It will be triaged again labels May 23, 2022
@lahabana
Copy link
Contributor Author

Let's fix this when we actually need it

@github-actions
Copy link
Contributor

Automatically closing the issue due to having one of the "closed state label".

@lahabana lahabana reopened this Jul 17, 2023
@github-actions
Copy link
Contributor

Removing closed state labels due to the issue being reopened.

@github-actions github-actions bot added the triage/pending This issue will be looked at on the next triage meeting label Jul 17, 2023
@lahabana
Copy link
Contributor Author

This came up recently. Reopening it

@github-actions github-actions bot removed the triage/rotten closed due to lack of information for too long, rejected feature... label Jul 17, 2023
@lahabana lahabana changed the title Replace usages of patrickmn/go-cache with goburrow/cache Replace usages of patrickmn/go-cache with a better cache Jul 17, 2023
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it kind/improvement Improvement on an existing feature and removed triage/pending This issue will be looked at on the next triage meeting labels Jul 24, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 23, 2023
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Nov 2, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Feb 7, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@bartsmykla bartsmykla removed the triage/stale Inactive for some time. It will be triaged again label May 14, 2024
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Aug 19, 2024
@lahabana
Copy link
Contributor Author

This has been around for long and if ever we decide to do it it'll probably be motivated by perf tests.

Closing

@lahabana lahabana closed this as not planned Won't fix, can't repro, duplicate, stale Sep 17, 2024
@lahabana lahabana added triage/rotten closed due to lack of information for too long, rejected feature... and removed triage/accepted The issue was reviewed and is complete enough to start working on it labels Sep 17, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement Improvement on an existing feature triage/rotten closed due to lack of information for too long, rejected feature...
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lahabana @slonka @jakubdyszkiewicz @bartsmykla @lukidzi