Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate conformance profiles suite flag values #2178

Open
mlavacca opened this issue Jul 11, 2023 · 10 comments · May be fixed by #3715
Open

Validate conformance profiles suite flag values #2178

mlavacca opened this issue Jul 11, 2023 · 10 comments · May be fixed by #3715
Assignees
@mlavacca
Labels
area/conformance-machinery Issues or PRs related to the machinery and the suite used to run conformance tests. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mlavacca
Copy link
Member

mlavacca commented Jul 11, 2023 •
edited
Loading

What would you like to be added:

#2066 added a new CLI to run conformance profiles. This CLI accepts
the following flags related to the implementation running the test suite:

  • organization
  • project
  • url
  • version
  • contact

We need to validate that:

  • the fields are not empty
  • url is a valid url
@mlavacca mlavacca added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 11, 2023
@mlavacca
Copy link
Member Author

/area conformance

@k8s-ci-robot k8s-ci-robot added the area/conformance-test Issues or PRs related to Conformance tests. label Jul 11, 2023
@mlavacca mlavacca mentioned this issue Jul 11, 2023
Merged
@shaneutt shaneutt added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 11, 2023
@shaneutt
Copy link
Member

Seems like some good smaller improvements.

/triage accepted

I hesitate to consider it a good-first-issue because it requires someone work on the experimental CLI, and have an implementation they're attaching to conformance, e.t.c. but I do think it's relatively low-hanging fruit for anyone already in that boat.

Not required for GA, but should be worked on not too long after that.

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Jul 21, 2023
@shaneutt shaneutt removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jul 21, 2023
@sunjayBhatia
Copy link
Member

I would argue version could maybe be a commit SHA or something similar not necessarily only a semver

@shaneutt
Copy link
Member

I would argue version could maybe be a commit SHA or something similar not necessarily only a semver

That within itself may be a good reason to do a small GEP update only doing that so we can work through it and discuss it.

@tssurya
Copy link

tssurya commented Sep 23, 2023

/cc

@k8s-triage-robot
Copy link

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. and removed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Sep 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 21, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 20, 2025
@mlavacca
Copy link
Member Author

This is still relevant.

/reopen
/assign

@mlavacca
Copy link
Member Author

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 20, 2025
@mlavacca mlavacca added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 20, 2025
@mlavacca mlavacca removed the area/conformance-test Issues or PRs related to Conformance tests. label Mar 27, 2025
@mlavacca mlavacca added the area/conformance-machinery Issues or PRs related to the machinery and the suite used to run conformance tests. label Mar 27, 2025
@mlavacca mlavacca linked a pull request Mar 27, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlavacca mlavacca

Labels
area/conformance-machinery Issues or PRs related to the machinery and the suite used to run conformance tests. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(conformance): validate implementation flags mlavacca/gateway-api
6 participants
@tssurya @shaneutt @sunjayBhatia @k8s-ci-robot @mlavacca @k8s-triage-robot