Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GatewayHTTPListenerIsolation (and other features) are listed as both Standard and Extended #3693

Closed
candita opened this issue Mar 19, 2025 · 4 comments
Labels
area/conformance-test Issues or PRs related to Conformance tests. kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Milestone

Comments

@candita
Copy link
Contributor

candita commented Mar 19, 2025

What happened:
https://github.com/kubernetes-sigs/gateway-api/blob/main/pkg/features/gateway.go#L80-L84 shows it as Standard and https://github.com/kubernetes-sigs/gateway-api/blob/main/pkg/features/gateway.go#L103 shows it as extended.

What you expected to happen:
A feature should be either Standard or Extended so that we can test Standard conformance separately from extended conformance.

How to reproduce it (as minimally and precisely as possible):
n/a

Anything else we need to know?:
When conformance tests run, the feature shows up in both supported and unsupported stanzas. There are numerous places in the feature code where features exist as both standard and extended.

@candita candita added the kind/bug Categorizes issue or PR as related to a bug. label Mar 19, 2025
@candita
Copy link
Contributor Author

candita commented Mar 19, 2025

/label area/conformance

@k8s-ci-robot
Copy link
Contributor

@candita: The label(s) /label area/conformance cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, ci-short, ci-extended, ci-full. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label area/conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@candita
Copy link
Contributor Author

candita commented Mar 19, 2025

/area conformance

@k8s-ci-robot k8s-ci-robot added the area/conformance-test Issues or PRs related to Conformance tests. label Mar 19, 2025
@candita candita changed the title GatewayHTTPListenerIsolation is listed as both Standard and Extended GatewayHTTPListenerIsolation (and other features) are listed as both Standard and Extended Mar 20, 2025
@shaneutt shaneutt added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 20, 2025
@shaneutt shaneutt moved this to Triage in Gateway API Pipeline Mar 20, 2025
@shaneutt shaneutt added this to the v1.3.0 milestone Mar 20, 2025
@mlavacca
Copy link
Member

This is not a bug. The concept of channel (standard/experimental) and feature type (core/extended) are orthogonal: The feature GatewayHTTPListenerIsolation is an extended feature related to the spec belonging to the standard channel.

I'm closing the issue. Feel free to re-open it if you deem it necessary.

@mlavacca mlavacca closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Gateway API Pipeline Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/conformance-test Issues or PRs related to Conformance tests. kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

4 participants