-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the validation limits within the API #2883
Comments
/triage accepted |
@robscott: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @robscott , I would love to work on this. TBH I am really new, but all the new folk friendly ones have been assigned and this one looks like the easiest to me. |
/assign |
Great to see some interest in this one, but I think the action to take here is probably going to need to be something that parses the Go types (or the CRD spec YAMLs that are generated from them), pulls out the validation limits, and generates a reference page (or adds to the existing reference page somehow). Any manually-created thing is inevitably going to fall out of date. |
@youngnick thanks for the insight , can you please guide me further |
I would say worry about getting the content somewhere that makes sense to you and then keep it simple to move it as needed as we progress. Thanks for taking this one on @abhayakyy! |
/assign |
Actually, as of #3703 if not before, we've switched to a new CRD docs generator that now includes limitations in the Reference pages on the site - for example, check the live docs here https://gateway-api.sigs.k8s.io/reference/spec/#gatewayspec. Sorry @darshansreenivas, I think that this one is already done! Thanks very much for volunteering to fix it. I'll close it to prevent this sort of thing happening again. /close |
@youngnick: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What would you like to be added:
Throughout the API we have a number of validations such as min and max length. We should include some centralized documentation that covers these limits.
Why this is needed:
These limits are unfortunately not documented anywhere, and it can result in confusion when users run into them.
The text was updated successfully, but these errors were encountered: