Skip to content

Commit f64636c

Browse files
committed
Clarifying what should happen when Gateway hostname is ""
We want this field to be optional as a pointer because it will be irrelevant for many protocols. That leaves us with three potential states, and this comment only covered two of them.
1 parent afbd2cc commit f64636c

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

apis/v1alpha1/gateway_types.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,9 @@ type GatewaySpec struct {
134134
// validating webhook.
135135
type Listener struct {
136136
// Hostname specifies the virtual hostname to match for protocol types that
137-
// define this concept. When unspecified or "*", all hostnames are matched.
138-
// This field can be omitted for protocols that don't require hostname based
139-
// matching.
137+
// define this concept. When unspecified, "", or "*", all hostnames are
138+
// matched. This field can be omitted for protocols that don't require
139+
// hostname based matching.
140140
//
141141
// Hostname is the fully qualified domain name of a network host, as defined
142142
// by RFC 3986. Note the following deviations from the "host" part of the

config/crd/bases/networking.x-k8s.io_gateways.yaml

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs-src/spec.md

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/spec/index.html

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)