Skip to content

Commit def9c89

Browse files
authored
Merge pull request #528 from danehans/issue_313
Updates RouteStatus Godocs
2 parents 85792a1 + 53ac7da commit def9c89

7 files changed

+44
-41
lines changed

apis/v1alpha1/shared_types.go

+12-11
Original file line numberDiff line numberDiff line change
@@ -187,10 +187,10 @@ type RouteGatewayStatus struct {
187187
GatewayRef GatewayReference `json:"gatewayRef"`
188188

189189
// Conditions describes the status of the route with respect to the
190-
// Gateway. For example, the "Admitted" condition indicates whether the
191-
// route has been admitted or rejected by the Gateway, and why. Note
192-
// that the route's availability is also subject to the Gateway's own
193-
// status conditions and listener status.
190+
// Gateway. The "Admitted" condition must always be specified by controllers
191+
// to indicate whether the route has been admitted or rejected by the Gateway,
192+
// and why. Note that the route's availability is also subject to the Gateway's
193+
// own status conditions and listener status.
194194
//
195195
// +listType=map
196196
// +listMapKey=type
@@ -201,16 +201,17 @@ type RouteGatewayStatus struct {
201201
// RouteStatus defines the observed state that is required across
202202
// all route types.
203203
type RouteStatus struct {
204-
// Gateways is a list of the Gateways that are associated with the
205-
// route, and the status of the route with respect to each of these
206-
// Gateways. When a Gateway selects this route, the controller that
207-
// manages the Gateway should add an entry to this list when the
208-
// controller first sees the route and should update the entry as
209-
// appropriate when the route is modified.
204+
// Gateways is a list of Gateways that are associated with the route,
205+
// and the status of the route with respect to each Gateway. When a
206+
// Gateway selects this route, the controller that manages the Gateway
207+
// must add an entry to this list when the controller first sees the
208+
// route and should update the entry as appropriate when the route is
209+
// modified.
210210
//
211211
// A maximum of 100 Gateways will be represented in this list. If this list
212212
// is full, there may be additional Gateways using this Route that are not
213-
// included in the list.
213+
// included in the list. An empty list means the route has not been admitted
214+
// by any Gateway.
214215
//
215216
// +kubebuilder:validation:MaxItems=100
216217
Gateways []RouteGatewayStatus `json:"gateways"`

config/crd/bases/networking.x-k8s.io_httproutes.yaml

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/networking.x-k8s.io_tcproutes.yaml

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/networking.x-k8s.io_tlsroutes.yaml

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/bases/networking.x-k8s.io_udproutes.yaml

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs-src/spec.md

+12-11
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/spec/index.html

+12-11
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)