Skip to content

Commit db85ff6

Browse files
committed
pass exept features to suite
1 parent 610a729 commit db85ff6

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

conformance/conformance_test.go

+1-3
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,9 @@ func TestConformance(t *testing.T) {
6666
Debug: *flags.ShowDebug,
6767
CleanupBaseResources: *flags.CleanupBaseResources,
6868
SupportedFeatures: supportedFeatures,
69+
ExemptFeatures: exemptFeatures,
6970
EnableAllSupportedFeatures: *flags.EnableAllSupportedFeatures,
7071
})
71-
for feature := range exemptFeatures {
72-
cSuite.SupportedFeatures.Delete(feature)
73-
}
7472
cSuite.Setup(t)
7573

7674
cSuite.Run(t, tests.ConformanceTests)

conformance/utils/suite/suite.go

+5
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ type Options struct {
7474
// resources such as Gateways should be cleaned up after the run.
7575
CleanupBaseResources bool
7676
SupportedFeatures sets.Set[SupportedFeature]
77+
ExemptFeatures sets.Set[SupportedFeature]
7778
EnableAllSupportedFeatures bool
7879
TimeoutConfig config.TimeoutConfig
7980
// SkipTests contains all the tests not to be run and can be used to opt out
@@ -102,6 +103,10 @@ func New(s Options) *ConformanceTestSuite {
102103
}
103104
}
104105

106+
for feature := range s.ExemptFeatures {
107+
s.SupportedFeatures.Delete(feature)
108+
}
109+
105110
if s.FS == nil {
106111
s.FS = &conformance.Manifests
107112
}

0 commit comments

Comments
 (0)