Remove validating webhook

Author: robscott

.github/ISSUE_TEMPLATE/bug.md

@@ -5,12 +5,11 @@ labels: kind/bug
 
 ---
 <!--
-Thank you for your interest in Gateway API! Please note that bug reports 
+Thank you for your interest in Gateway API! Please note that bug reports
 here should only be used for bugs with the API itself, such as:
 
 - Incomplete or inaccurate validation
 - Problems with the API specification
-- Unexpected errors with the validating webhook
 - Flaws in conformance tests
 
 Bugs that don't fit into one of the above categories should likely be filed

.gitignore

@@ -50,7 +50,6 @@ Session.vim
 /www/test_out
 .*.timestamp
 /site
-admission
 go.work
 go.work.sum
 

Makefile

@@ -58,16 +58,12 @@ all: generate vet fmt verify test
 
 # Run generators for protos, Deepcopy funcs, CRDs, and docs.
 .PHONY: generate
-generate: update-codegen update-webhook-yaml
+generate: update-codegen
 
 .PHONY: update-codegen
 update-codegen:
 	hack/update-codegen.sh
 
-.PHONY: update-webhook-yaml
-update-webhook-yaml:
-	hack/update-webhook-yaml.sh
-
 .PHONY: build-install-yaml
 build-install-yaml:
 	hack/build-install-yaml.sh
@@ -82,7 +78,7 @@ vet:
 
 # Run go test against code
 test:
-	go test -race -cover ./pkg/admission/... ./apis/... ./conformance/utils/...
+	go test -race -cover ./apis/... ./conformance/utils/...
 # Run tests for each submodule.
 	cd "conformance/echo-basic" && go test -race -cover ./...
 	cd "gwctl" && go test -race -cover ./...

RELEASE.md

@@ -43,10 +43,9 @@ For a **PATCH** release:
 - Use `git` to cherry-pick all relevant PRs into your branch.
 - Update `pkg/generator/main.go` with the new semver tag and any updates to the API review URL.
 - Run the following command `BASE_REF=vmajor.minor.patch make generate` which
-  will update generated docs and webhook with the correct version info. (Note
-  that you can't test with these YAMLs yet as they contain references to
-  elements which wont exist until the tag is cut and image is promoted to
-  production registry.)
+  will update generated docs with the correct version info. (Note that you can't
+  test with these YAMLs yet as they contain references to elements which wont
+  exist until the tag is cut and image is promoted to production registry.)
 - Create a pull request of the `<githubuser>/release-x.x.x` branch into the `release-x.x` branch upstream
   (which should already exist since this is a patch release). Add a hold on this PR waiting for at least
   one maintainer/codeowner to provide a `lgtm`.
@@ -62,10 +61,9 @@ For a **MAJOR** or **MINOR** release:
 - Check out the `release-major.minor` release branch locally.
 - Update `pkg/generator/main.go` with the new semver tag and any updates to the API review URL.
 - Run the following command `BASE_REF=vmajor.minor.patch make generate` which
-  will update generated docs and webhook with the correct version info. (Note
-  that you can't test with these YAMLs yet as they contain references to
-  elements which wont exist until the tag is cut and image is promoted to
-  production registry.)
+  will update generated docs with the correct version info. (Note that you can't
+  test with these YAMLs yet as they contain references to elements which wont
+  exist until the tag is cut and image is promoted to production registry.)
 - Verify the CI tests pass before continuing.
 - Create a tag using the `HEAD` of the `release-x.x` branch. This can be done using the `git` CLI or
   Github's [release][release] page.
@@ -76,10 +74,9 @@ For a **MAJOR** or **MINOR** release:
 For an **RC** release:
 - Update `pkg/generator/main.go` with the new semver tag and any updates to the API review URL.
 - Run the following command `BASE_REF=vmajor.minor.patch make generate` which
-  will update generated docs and webhook with the correct version info. (Note
-  that you can't test with these YAMLs yet as they contain references to
-  elements which wont exist until the tag is cut and image is promoted to
-  production registry.)
+  will update generated docs with the correct version info. (Note that you can't
+  test with these YAMLs yet as they contain references to elements which wont
+  exist until the tag is cut and image is promoted to production registry.)
 - Include the changelog update in this PR.
 - Merge the update PR.
 - Tag the release using the commit on `main` where the changelog update merged.
@@ -90,7 +87,7 @@ For an **RC** release:
 - Attach these files to the Github release.
 
 ### Promoting images to production registry
-Gateway API follows the standard kubernetes image promotion process described [here][kubernetes-image-promotion]. 
+Gateway API follows the standard kubernetes image promotion process described [here][kubernetes-image-promotion].
 
 1. Once the tag has been cut and the image is available in the staging registry,
    identify the SHA-256 image digest of the image that you want to promote.

apis/v1/gateway_types.go

@@ -56,8 +56,8 @@ type GatewayList struct {
 // GatewaySpec defines the desired state of Gateway.
 //
 // Not all possible combinations of options specified in the Spec are
-// valid. Some invalid configurations can be caught synchronously via a
-// webhook, but there are many cases that will require asynchronous
+// valid. Some invalid configurations can be caught synchronously via CRD
+// validation, but there are many cases that will require asynchronous
 // signaling via the GatewayStatus block.
 type GatewaySpec struct {
 	// GatewayClassName used for this Gateway. This is the name of a

apis/v1/httproute_types.go

@@ -821,7 +821,7 @@ type HTTPHeader struct {
 // HTTPHeaderFilter defines a filter that modifies the headers of an HTTP
 // request or response. Only one action for a given header name is permitted.
 // Filters specifying multiple actions of the same or different type for any one
-// header name are invalid and will be rejected by the webhook if installed.
+// header name are invalid and will be rejected by CRD validation.
 // Configuration to set or add multiple values for a header must use RFC 7230
 // header value formatting, separating each value with a comma.
 type HTTPHeaderFilter struct {