This repository was archived by the owner on Mar 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 509
/
Copy pathrequire-arrow-functions.js
88 lines (79 loc) · 2.13 KB
/
require-arrow-functions.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
/**
* Requires that arrow functions are used instead of anonymous function expressions in callbacks.
*
* Type: `Boolean`
*
* Value: `true`
*
* Version: `ES6`
*
* #### Example
*
* ```js
* "requireArrowFunctions": true
* ```
*
* ##### Valid
*
* ```js
* // arrow function
* [1, 2, 3].map((x) => {
* return x * x;
* });
* // function declaration
* function a(n) { return n + 1; }
* // getter/setter
* var x = { get y() {}, set y(y) {} }
* // object shorthand
* var x = { bar() {} }
* // class method
* class Foo { bar() {} }
* // function expression in a return statement
* function a(x) {
* return function(x) { return x };
* };
* // function expression in a variable declaration
* var a = function(x) { return x };
* ```
*
* ##### Invalid
*
* ```js
* // function expression in a callback
* [1, 2, 3].map(function (x) {
* return x * x;
* });
* ```
*/
var assert = require('assert');
module.exports = function() {};
module.exports.prototype = {
configure: function(options) {
assert(
options === true,
this.getOptionName() + ' option requires a true value or should be removed'
);
},
getOptionName: function() {
return 'requireArrowFunctions';
},
check: function(file, errors) {
function isCallback(node) {
return node.type === 'FunctionExpression' && node.parentElement.type === 'CallExpression';
}
function isFunctionBindWithThis(node) {
return node.callee &&
node.callee.type === 'MemberExpression' &&
node.callee.object.type === 'FunctionExpression' &&
node.callee.property.type === 'Identifier' &&
node.callee.property.name === 'bind' &&
node.arguments &&
node.arguments.length === 1 && node.arguments[0].type === 'ThisExpression';
}
file.iterateNodesByType(['FunctionExpression', 'CallExpression'], function(node) {
if (isCallback(node) || isFunctionBindWithThis(node)) {
errors.add('Use arrow functions instead of function expressions', node);
}
});
}
};