Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons in release build have a larger file size and are blurry #2339

Closed
M393 opened this issue Mar 17, 2025 · 3 comments · Fixed by jquery/download.jqueryui.com#635
Closed

Icons in release build have a larger file size and are blurry #2339

M393 opened this issue Mar 17, 2025 · 3 comments · Fixed by jquery/download.jqueryui.com#635
Assignees
@mgol
Labels
Comp: Core
Milestone
1.14.2

Comments

@M393
Copy link

M393 commented Mar 17, 2025

Compare the icons from the zip with the ones checked in in git:
https://jqueryui.com/resources/download/jquery-ui-1.14.1.zip

file git dist
ui-icons_444444_256x240.png 3266 6978
ui-icons_555555_256x240.png 3274 6985
ui-icons_777620_256x240.png 3262 4510
ui-icons_777777_256x240.png 3266 7006
ui-icons_cc0000_256x240.png 3262 4510
ui-icons_ffffff_256x240.png 3264 6403
@mgol mgol self-assigned this Mar 21, 2025
@mgol
Copy link
Member

mgol commented Mar 21, 2025

Thanks for the report. The file size has always been larger but the blur is too high and it used to be lower in 1.12.1. We'll fix it for the next release.

@mgol mgol added this to the 1.14.2 milestone Mar 21, 2025
mgol added a commit to mgol/download.jqueryui.com that referenced this issue Mar 24, 2025
@mgol
Themeroller: Fix alpha treatment in icons
b992506 
Since jQuery UI 1.13.0, partially transparent pixels in the icons file started
being too dark. Set gamma to 0.5 for the A channel to get closer to the 1.12.1
output.

A test comparing similarity of the generated image to the jQuery 1.12.1 has been
added as well.

Fixes jquery/jquery-ui#2339
@mgol mgol mentioned this issue Mar 24, 2025
Merged
mgol added a commit to mgol/download.jqueryui.com that referenced this issue Mar 24, 2025
@mgol
Themeroller: Fix alpha treatment in icons
4320218 
Since jQuery UI 1.13.0, partially transparent pixels in the icons file started
being too dark. Set gamma to 0.5 for the A channel to get closer to the 1.12.1
output.

A test comparing similarity of the generated image to the jQuery 1.12.1 has been
added as well.

Fixes jquery/jquery-ui#2339
@mgol
Copy link
Member

mgol commented Mar 24, 2025

Fix at jquery/download.jqueryui.com#635

mgol added a commit to jquery/jqueryui.com that referenced this issue Mar 24, 2025
@mgol
Build: Update download.jqueryui.com from 2.4.3 to 2.4.4
fed5fb0 
This fixes icons being too dark & blurry.

Fixes jquery/jquery-ui#2339
@mgol
Copy link
Member

mgol commented Mar 24, 2025

This should be fixed now. The zip you mentioned will only be fixed for jQuery UI 1.14.2 or newer, but the Download Builder now builds correct sprites even for older releases, so you can just go to https://jqueryui.com/download/, choose everything and click Download to get a fixed version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgol mgol

Labels
Comp: Core
Milestone
1.14.2
Development

Successfully merging a pull request may close this issue.

Themeroller: Fix alpha treatment in icons mgol/download.jqueryui.com
2 participants
@mgol @M393