Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE filter property has incorrect value for the widget-overlay v1.13 #2190

Closed
Diazole opened this issue Oct 17, 2023 · 6 comments · Fixed by jquery-archive/jquery-ui-themeroller#19 or jquery/download.jqueryui.com#612
Closed

IE filter property has incorrect value for the widget-overlay v1.13 #2190

Diazole opened this issue Oct 17, 2023 · 6 comments · Fixed by jquery-archive/jquery-ui-themeroller#19 or jquery/download.jqueryui.com#612
Labels
Behavior different from 1.12 Bug Comp: Theme
Milestone
1.13.3

Comments

@Diazole
Copy link

Diazole commented Oct 17, 2023

IE filter property values were updated to strings by #1939.

However, the filter value for the widget-overlay hasn't been updated in the output CSS file (https://github.com/jquery/jquery-ui/blob/1.13.2/dist/themes/base/theme.css#L441).

All of the other filters have been updated to strings in the output file, so I'm not sure why this one wasn't?
@Diazole
Copy link
Author

Diazole commented Oct 17, 2023

The v1.13.2 stable release has:

/* Overlays */
.ui-widget-overlay {
	background: #aaaaaa;
	opacity: .003;
	-ms-filter: Alpha(Opacity=.3); /* support: IE8 */
}

But the base theme for v1.13.2 has:

/* Overlays */
.ui-widget-overlay {
	background: #aaaaaa/*{bgColorOverlay}*/ /*{bgImgUrlOverlay}*/ /*{bgOverlayXPos}*/ /*{bgOverlayYPos}*/ /*{bgOverlayRepeat}*/;
	opacity: .3/*{opacityOverlay}*/;
	-ms-filter: "alpha(opacity=30)"/*{opacityFilterOverlay}*/; /* support: IE8 */
}

So not only is the filter different, the opacity is too?

@mgol
Copy link
Member

mgol commented Oct 19, 2023

The values in curly braces are variable names that are supposed to substitute the default values, based on the theme used.

We probably need to update the opacityFilterOverlay values.

It looks like the issue is in themeroller: https://github.com/jquery/jquery-ui-themeroller/blob/71ccc63fbe0744987743ecf83bcedde460c3165a/lib/themeroller.js#L119-L122.

Would you like to submit a PR?

@mgol mgol added this to the 1.13.3 milestone Oct 19, 2023
@slominskir slominskir mentioned this issue Dec 14, 2023
Closed
@mcanepa mcanepa mentioned this issue Jan 3, 2024
Closed
@mcanepa
Copy link
Contributor

mcanepa commented Jan 3, 2024

@mgol does #15 fix this?

@mgol mgol added the Bug label Apr 8, 2024
mgol added a commit to mgol/jquery-ui-themeroller that referenced this issue Apr 20, 2024
@mgol
Fix -ms-filter calculations for jQuery UI 1.13
8b89763 
jQuery UI 1.13 uses `-ms-filter` which has to have its entire value put
in quotes.

Fixes jquery/jquery-ui/issues/2190
@mgol mgol mentioned this issue Apr 20, 2024
Merged
@mgol
Copy link
Member

mgol commented Apr 20, 2024

PR for jquery-ui-themeroller at jquery-archive/jquery-ui-themeroller#19, I'll also submit a separate one for the Download Builder which currently has a separate version of themeroller (I'll wait with straightening this out until jQuery UI 1.14).

mgol added a commit to mgol/jquery-ui-themeroller that referenced this issue Apr 20, 2024
@mgol
Fix -ms-filter calculations for jQuery UI 1.13
4b1ab93 
jQuery UI 1.13 uses `-ms-filter` which has to have its entire value put
in quotes.

Fixes jquery/jquery-ui/issues/2190
mgol added a commit to mgol/download.jqueryui.com that referenced this issue Apr 21, 2024
@mgol
Fix -ms-filter calculations for jQuery UI 1.13
aa2a3f4 
jQuery UI 1.13 uses `-ms-filter` which has to have its entire value put
in quotes.

Fixes jquery/jquery-ui/issues/2190
@mgol mgol mentioned this issue Apr 21, 2024
Merged
@mgol
Copy link
Member

mgol commented Apr 21, 2024

PR for the Download Builder repo: jquery/download.jqueryui.com#612

@mgol
Copy link
Member

mgol commented Apr 21, 2024

Re-opening since only the jquery-ui-themeroller PR landed so far.

@mgol mgol reopened this Apr 21, 2024
@mgol mgol reopened this Apr 21, 2024
mgol added a commit to mgol/download.jqueryui.com that referenced this issue Apr 21, 2024
@mgol
Fix -ms-filter calculations for jQuery UI 1.13
3f8066b 
jQuery UI 1.13 uses `-ms-filter` which has to have its entire value put
in quotes.

Fixes jquery/jquery-ui/issues/2190
mgol added a commit to jquery/download.jqueryui.com that referenced this issue Apr 21, 2024
@mgol
Fix -ms-filter calculations for jQuery UI 1.13
df71103 
jQuery UI 1.13 uses `-ms-filter` which has to have its entire value put
in quotes.

Fixes jquery/jquery-ui/issues/2190
Closes gh-612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Behavior different from 1.12 Bug Comp: Theme
Milestone
1.13.3
3 participants
@mgol @Diazole @mcanepa