Build: Enable no-unused-vars in ESLint, fix violations

Ref gh-615

Author: mgol

app/src/download.js

@@ -8,7 +8,7 @@
  * Released under the MIT license.
  * https://jquery.org/license
  */
-( function( $, Hash, JST, Model, undefined ) {
+( function( $, Hash, JST, Model ) {
 	"use strict";
 
 	var dependencies, dependents, model,

app/src/hash.js

@@ -7,7 +7,7 @@
  * Released under the MIT license.
  * https://jquery.org/license
  */
-( function( exports, $, EventEmitter, undefined ) {
+( function( exports, $, EventEmitter ) {
 	"use strict";
 
 	var emitter = new EventEmitter(),

app/src/model.js

@@ -8,7 +8,7 @@
  * Released under the MIT license.
  * https://jquery.org/license
  */
-( function( exports, $, EventEmitter, LZMA, QueryString, undefined ) {
+( function( exports, $, EventEmitter, LZMA, QueryString ) {
 	"use strict";
 
 	var Model, DownloadBuilderModel, ThemeRollerModel,
@@ -294,7 +294,7 @@
 				df2.resolve();
 			} else {
 				this.orderedComponentsDfd.done( function() {
-					var booleansArray = $.map( self.orderedComponents, function( component, i ) {
+					var booleansArray = $.map( self.orderedComponents, function( component ) {
 
 						// Each component is true by default.
 						return !( component in attributes ) ? true : attributes[ component ];
@@ -335,8 +335,7 @@
 		},
 
 		themerollerUrl: function( callback ) {
-			var self = this, themeParams,
-				attributes = this.attributes;
+			var self = this, themeParams;
 
 			this.themeParamsUnzipping.done( function() {
 				themeParams = ( self.has.call( self, "themeParams" ) && self.get.call( self, "themeParams" ) !== "none" ? QueryString.decode( self.get.call( self, "themeParams" ) ) : {} );

app/src/querystring.js

@@ -1,13 +1,12 @@
 /* eslint-env jquery, browser */
-/*global EventEmitter: false */
 /*!
  * jQuery UI helper JavaScript file for QueryString support
  *
  * Copyright OpenJS Foundation and other contributors
  * Released under the MIT license.
  * https://jquery.org/license
  */
-( function( exports, $, undefined ) {
+( function( exports, $ ) {
 	"use strict";
 
 	var QueryString = exports.QueryString = {};

app/src/themeroller.js

@@ -8,7 +8,7 @@
  * Released under the MIT license.
  * https://jquery.org/license
  */
-( function( $, Hash, JST, Model, QueryString, undefined ) {
+( function( $, Hash, JST, Model, QueryString ) {
 	"use strict";
 
 	var farbtasticTriggerChangeDelay, model, reloadRollYourOwn, skipHashChange,
@@ -156,7 +156,7 @@
 						} )
 					};
 				},
-				corner: function( attributes ) {
+				corner: function() {
 					return {
 						isCornerType: true
 					};
@@ -435,7 +435,6 @@
 
 			$( this ).after( "<div class=\"texturePicker\"><a href=\"#\"></a><ul></ul></div>" );
 			var texturePicker = $( this ).next(),
-				a = texturePicker.find( "a" ),
 				ul = texturePicker.find( "ul" ),
 				sIndex = texturePicker.prev().get( 0 ).selectedIndex;
 

download.js

@@ -39,7 +39,6 @@ Handlebars.registerHelper( "join", function( array, sep, options ) {
 
 var indexTemplate = Handlebars.compile( fs.readFileSync( __dirname + "/template/download/index.html", "utf8" ) ),
 	jsonpTemplate = Handlebars.compile( fs.readFileSync( __dirname + "/template/jsonp.js", "utf8" ) ),
-	themeTemplate = Handlebars.compile( fs.readFileSync( __dirname + "/template/download/theme.html", "utf8" ) ),
 	wrapTemplate = Handlebars.compile( fs.readFileSync( __dirname + "/template/download/wrap.html", "utf8" ) );
 
 var Frontend = function( args ) {
@@ -91,7 +90,7 @@ Frontend.prototype = {
 
 	create: function( fields, response, callback ) {
 		try {
-			var builder, components, jqueryUi, Package, packer, packager, start, theme,
+			var components, jqueryUi, Package, packager,
 				themeVars = null;
 
 			// If fields.theme is unexpectedly absent, consider it as "none".

eslint.config.mjs

@@ -39,7 +39,7 @@ export default [
 			// Too many violations
 			"camelcase": "off",
 			"max-len": "off",
-			"no-unused-vars": "off"
+			"no-unused-vars": "error"
 		}
 	},
 
@@ -64,6 +64,7 @@ export default [
 	{
 		files: [ "app/src/**/*.js" ],
 		languageOptions: {
+
 			// No need to keep IE support, so we could bump it to ES2022 as well,
 			// but we need to switch the minifier to something other than UglifJS
 			// which is ES5-only.

lib/jquery-ui-files.js

@@ -1,6 +1,6 @@
 "use strict";
 
-var flatten, stripBanner,
+var stripBanner,
 	banner = require( "./banner" ),
 	fs = require( "node:fs" ),
 	JqueryUiFiles_1_12_0 = require( "./jquery-ui-files-1-12" ),
@@ -10,7 +10,6 @@ var flatten, stripBanner,
 	util = require( "./util" ),
 	filesCache = {};
 
-flatten = util.flatten;
 stripBanner = util.stripBanner;
 
 function replaceVersion( data, version ) {

lib/themeroller.js

@@ -1,6 +1,6 @@
 "use strict";
 
-var colorVars, iconDimension, textureVars, themeStaticCss,
+var colorVars, textureVars, themeStaticCss,
 	_ = require( "underscore" ),
 	async = require( "async" ),
 	Image = require( "./themeroller-image" ),
@@ -38,7 +38,7 @@ function cssYPos( texture, context ) {
 }
 
 // Hard coded css X image positioning - context accepts button or panel
-function cssXPos( texture, context ) {
+function cssXPos( texture ) {
 	if ( texture === "flat" ) {
 		return "";
 	}
@@ -59,7 +59,7 @@ function hashColor( color ) {
 // Update textureVars from previous filename format (eg. 02_glass.png) to type-only format (eg. glass). Changed on images generation rewrite (port to nodejs).
 function oldImagesBackCompat( vars ) {
 	textureVars.forEach( function( textureVar ) {
-		var newValue, pair, value;
+		var newValue, value;
 		if ( textureVar in vars ) {
 			value = vars[ textureVar ];
 			newValue = value.replace( /[0-9]*_([^\.]*).png/, "$1" );
@@ -75,8 +75,6 @@ textures = textures.reduce( function( sum, texture ) {
 	return sum;
 }, {} );
 
-iconDimension = [ "256", "240" ];
-
 
 /**
  * ThemeRoller
@@ -316,8 +314,7 @@ ThemeRoller.prototype = {
 			callback( null, [] );
 			return;
 		}
-		var self = this,
-			generated = {};
+		var generated = {};
 		async.parallel( this.images.map( function( image ) {
 			return function( callback ) {
 				image.get( function( err, filename, data ) {

server.js

@@ -38,7 +38,7 @@ if ( process.argv.indexOf( "--nocache" ) === -1 ) {
 	// Cache jquery-ui-themeroller images as well
 	async.forEachSeries( require( "./lib/themeroller-themegallery" )(), function( theme, callback ) {
 		theme = new( require( "jquery-ui-themeroller" ) )( "", theme.vars );
-		theme.generateImages( function( error, imageFiles ) {
+		theme.generateImages( function( error ) {
 			if ( error ) {
 				error.message = "Caching theme images (2): " + error.message;
 				callback( error );
@@ -71,7 +71,7 @@ function route( app ) {
 	} );
 	app.post( routes.download, function( request, response ) {
 		var form = formidable( {} );
-		form.parse( request, function( err, arrFields, files ) {
+		form.parse( request, function( err, arrFields ) {
 			if ( err ) {
 				return error( err, response );
 			}

test/package-1-12.0.js

@@ -1,6 +1,6 @@
 "use strict";
 
-var commonFiles, COMMON_FILES_TESTCASES, defaultTheme, newPackage, someWidgets1, someWidgets2, tests, themeFiles, THEME_FILES_TESTCASES,
+var commonFiles, COMMON_FILES_TESTCASES, defaultTheme, someWidgets1, someWidgets2, tests, themeFiles, THEME_FILES_TESTCASES,
 	JqueryUi = require( "../lib/jquery-ui" ),
 	Package = require( "../lib/package-1-12" ),
 	Packager = require( "node-packager" ),

test/package-1-13.0.js

@@ -1,6 +1,6 @@
 "use strict";
 
-var commonFiles, COMMON_FILES_TESTCASES, defaultTheme, newPackage, someWidgets1, someWidgets2, tests, themeFiles, THEME_FILES_TESTCASES,
+var commonFiles, COMMON_FILES_TESTCASES, defaultTheme, someWidgets1, someWidgets2, tests, themeFiles, THEME_FILES_TESTCASES,
 	JqueryUi = require( "../lib/jquery-ui" ),
 	Package = require( "../lib/package-1-13" ),
 	Packager = require( "node-packager" ),

themeroller.js

@@ -34,7 +34,6 @@ var appinterfaceTemplate = Handlebars.compile( fs.readFileSync( __dirname + "/te
 	demoTemplate = Handlebars.compile( fs.readFileSync( __dirname + "/template/themeroller/demo.html", "utf8" ) ),
 	helpTemplate = Handlebars.compile( fs.readFileSync( __dirname + "/template/themeroller/help.html", "utf8" ) ),
 	indexTemplate = Handlebars.compile( fs.readFileSync( __dirname + "/template/themeroller/index.html", "utf8" ) ),
-	jsonpTemplate = Handlebars.compile( fs.readFileSync( __dirname + "/template/jsonp.js", "utf8" ) ),
 	themegalleryTemplate = Handlebars.compile( fs.readFileSync( __dirname + "/template/themeroller/themegallery.html", "utf8" ) ),
 	wrapTemplate = Handlebars.compile( fs.readFileSync( __dirname + "/template/themeroller/wrap.html", "utf8" ) );
 
@@ -49,10 +48,7 @@ Frontend.prototype = {
 		if ( vars && "zThemeParams" in vars ) {
 			delete vars.zThemeParams;
 		}
-		var production = this.env.toLowerCase() === "production",
-			theme = new ThemeRoller( {
-				vars: vars
-			} );
+		var production = this.env.toLowerCase() === "production";
 		options = options || {};
 		if ( options.wrap ) {
 			options = _.defaults( {