De-lint files. Fixes #43

Author: rxaviers

download.js

@@ -45,7 +45,7 @@ Frontend.prototype = {
 	theme: function( params ) {
 		var selectedTheme = themeGallery[ 0 ];
 		if ( params.themeParams ) {
-			selectedTheme = new ThemeRoller( querystring.parse( unescape( params.themeParams ) ) );
+			selectedTheme = new ThemeRoller( querystring.parse( querystring.unescape( params.themeParams ) ) );
 		}
 		return jsonpTemplate({
 			callback: params.callback,

lib/builder.js

@@ -383,7 +383,7 @@ Builder.prototype = {
 			var zip = archiver.createZip();
 			zip.pipe( response );
 			async.forEachSeries( build, function( file, next ) {
-				if ( file.data == undefined ) {//null or undefined
+				if ( file.data == null ) {//null or undefined
 					throw new Error( "Builder: missing data of \"" + file.path + "\"" );
 				}
 				zip.addFile( file.data, { name: file.path }, next );

lib/themeroller.js

@@ -3,7 +3,7 @@ var _ = require( "underscore" ),
 	config = require( "../config" ),
 	fs = require( "fs" ),
 	http = require( "http" ),
-	logger = require( "simple-log" ).init( "download.jqueryui.com" );
+	logger = require( "simple-log" ).init( "download.jqueryui.com" ),
 	path = require( "path" ),
 	querystring = require( "querystring" ),
 	release = require( "./release" ).all()[ 0 ],
@@ -16,37 +16,37 @@ var colorVars = "bgColorActive bgColorContent bgColorDefault bgColorError bgColo
 // Hard coded css image repeats - universal to all contexts, depending on on image is designed
 function cssRepeat( image ) {
 	// Most textures repeat x
-	repeat = "repeat-x";
+	var repeat = "repeat-x";
 	// If tile pattern
 	if ( "07_diagonals_small.png 07_diagonals_medium.png 08_diagonals_thick.png 09_dots_small.png 10_dots_medium.png 11_white_lines.png 13_diamond.png 14_loop.png 15_carbon_fiber.png 16_diagonal_maze.png 17_diamond_ripple.png 18_hexagon.png 19_layered_circles.png 18_hexagon.png 20_3D_boxes.png 23_fine_grain.png".split( " " ).indexOf( image ) >= 0 ) {
 		repeat = "repeat";
 	}
 	return repeat;
 }
 
-// Hard coded css Y image positioning - image is image filename, context accepts button or panel 
+// Hard coded css Y image positioning - image is image filename, context accepts button or panel
 function cssYPos( image, context ){
-	YPos = "50%";
-	if( context == "panel" ){
-		if( image == "03_highlight_soft.png" || image == "04_highlight_hard.png" || image == "12_gloss_wave.png" ){
+	var YPos = "50%";
+	if( context === "panel" ){
+		if( image === "03_highlight_soft.png" || image === "04_highlight_hard.png" || image === "12_gloss_wave.png" ){
 			YPos = "top";
 		}
-		else if( image == "05_inset_soft.png" || image == "06_inset_hard.png" ){
+		else if( image === "05_inset_soft.png" || image === "06_inset_hard.png" ){
 			YPos = "bottom";
 		}
-		else if( image == "21_glow_ball.png" ){
+		else if( image === "21_glow_ball.png" ){
 			YPos = "35%";
 		}
-		else if( image == "22_spotlight.png" ){
+		else if( image === "22_spotlight.png" ){
 			YPos = "2%";
 		}
 	}
 	return YPos;
 }
 
-// Hard coded css X image positioning - image is image filename, context accepts button or panel 
+// Hard coded css X image positioning - image is image filename, context accepts button or panel
 function cssXPos( image, context ){
-	XPos = "50%";
+	var XPos = "50%";
 	// No conditions yet, may need some for vertical slider patterns
 	return XPos;
 }
@@ -63,6 +63,10 @@ var iconDimension = [ "256", "240" ];
  * ThemeRoller
  */
 function ThemeRoller( vars ) {
+	var found,
+		opacityFix,
+		self,
+		themeGallery;
 	if ( vars === false || vars === null ) {
 		this.isNull = true;
 		this.vars = {};
@@ -80,8 +84,8 @@ function ThemeRoller( vars ) {
 	this.images = {};
 
 	// Opacity fix (w3c + IE)
-	var opacityFix = function( opacity ) {
-		return ( /* w3c */ ( opacity == "100" || opacity == "0" ) ? opacity : parseFloat( "." + opacity, 10 ).toString().replace( /^0/, "" ) ) + /* IE */ ";filter:Alpha(Opacity=" + opacity + ")";
+	opacityFix = function( opacity ) {
+		return ( /* w3c */ ( opacity === "100" || opacity === "0" ) ? opacity : parseFloat( "." + opacity, 10 ).toString().replace( /^0/, "" ) ) + /* IE */ ";filter:Alpha(Opacity=" + opacity + ")";
 	};
 	vars.opacityOverlayPerc = vars.opacityOverlay;
 	vars.opacityShadowPerc = vars.opacityShadow;
@@ -146,10 +150,10 @@ function ThemeRoller( vars ) {
 
 	if ( !this.name ) {
 		// Pick name based on theme gallery vs. our vars
-		var themeGallery = require( "./themeroller.themegallery" ),
-			self = this;
+		themeGallery = require( "./themeroller.themegallery" );
+		self = this;
 		themeGallery.some(function( theme ) {
-			var found = theme.isEqual( self );
+			found = theme.isEqual( self );
 			if ( found ) {
 				self.name = theme.name;
 			}
@@ -168,7 +172,7 @@ function ThemeRoller( vars ) {
 }
 
 function expandColor( color ) {
-	if ( color.length == 3 ) {
+	if ( color.length === 3 ) {
 		return [ 0, 0, 1, 1, 2, 2 ].map(function( i ) {
 			return color[i];
 		}).join( "" );
@@ -178,7 +182,7 @@ function expandColor( color ) {
 
 ThemeRoller.prototype = {
 	_setImage: function( filename, url ) {
-		if ( typeof this.images[ filename ] == "undefined" ) {
+		if ( typeof this.images[ filename ] === "undefined" ) {
 			this.images[ filename ] = url;
 		}
 	},
@@ -200,7 +204,7 @@ ThemeRoller.prototype = {
 	},
 
 	_textureUrl: function( color, file, opacity ) {
-		if ( typeof textureDimensions[ file ] == "undefined" ) {
+		if ( typeof textureDimensions[ file ] === "undefined" ) {
 			throw new Error( "No dimensions set for texture \"" + file + "\"" );
 		}
 		var dimension, filename;
@@ -243,15 +247,15 @@ ThemeRoller.prototype = {
 					host: config.imageGeneratorHost,
 					path: [ config.imageGeneratorPath, self.images[ filename ] ].join( "/" )
 				}, function( res ) {
-					var buffer = [];
-					var dataLen = 0;
+					var buffer = [],
+						dataLen = 0;
 					res.on( "data", function ( chunk ) {
 						buffer.push( chunk );
 						dataLen += chunk.length;
 					});
 					res.on( "end", function () {
-						var i = 0;
-						var data = new Buffer( dataLen );
+						var i = 0,
+							data = new Buffer( dataLen );
 						buffer.forEach(function ( chunk ) {
 							chunk.copy( data, i, 0, chunk.length );
 							i += chunk.length;
@@ -286,7 +290,7 @@ ThemeRoller.prototype = {
 	isEqual: function( theme ) {
 		var self = this;
 		return Object.keys( this.vars ).every(function( key ) {
-			return self.vars[ key ] == theme.vars[ key ];
+			return self.vars[ key ] === theme.vars[ key ];
 		});
 	}
 };

themeroller.js

@@ -25,7 +25,7 @@ Handlebars.registerHelper( "textureOptions", function( select, panel ) {
 		}
 		// tall panel element (content, overlay, shadow, etc), don't allow glass texture
 		if ( panel === "true" ) {
-			if( texture.file != "02_glass.png" ) {
+			if( texture.file !== "02_glass.png" ) {
 				optSet += "<option value=\"" + texture.file + "\"" + selected + " data-texturewidth=\"" + texturedims[0] + "\" data-textureheight=\"" + texturedims[1] + "\">" + name + "</option>";
 			}
 		} else {
@@ -36,7 +36,7 @@ Handlebars.registerHelper( "textureOptions", function( select, panel ) {
 });
 
 Handlebars.registerHelper( "themeParams", function( serializedVars ) {
-	return serializedVars.length > 0 ? "?themeParams=" + escape( serializedVars ) : "";
+	return serializedVars.length > 0 ? "?themeParams=" + querystring.escape( serializedVars ) : "";
 });
 
 var appinterfaceTemplate = Handlebars.compile( fs.readFileSync( __dirname + "/template/themeroller/appinterface.html", "utf8" ) ),
@@ -91,7 +91,7 @@ Frontend.prototype = {
 	},
 
 	rollYourOwn: function( params ) {
-		var theme = new ThemeRoller( querystring.parse( unescape( params.themeParams ) ) );
+		var theme = new ThemeRoller( querystring.parse( querystring.unescape( params.themeParams ) ) );
 		return jsonpTemplate({
 				callback: params.callback,
 				data: JSON.stringify( rollyourownTemplate( theme ) )