All: Drop the modern-syslog dependency, always use console directly

Writing logs to syslog made sense when we run the Download Builder on machines
running a lot of other things. Now we're using Digital Ocean droplets where we
deploy Docker images which already provides isolation.

In addition to that, Digital Ocean provides a view of console logs, but the
build & deploy phases only print regular console logs, not syslog messages. This
made debugging a recent deploy crash much harder than it should have been.

Closes gh-631

Author: mgol

README.md

@@ -55,7 +55,6 @@ One version with the `stable` property set to `true` is required. Each release h
 ### node server.js
 
 Use `node server.js` to run the server. Arguments:
-- `--console` output to console instead of syslog (via simple-log module);
 - `--host=<name>` specify custom host. Default localhost;
 - `--nocache` skip caching release files and theme images;
 - `--port=<number>` specify custom port. Default 8088;

download.js

@@ -5,7 +5,6 @@ var cache, downloadLogger, jqueryUis,
 	fs = require( "node:fs" ),
 	Handlebars = require( "handlebars" ),
 	JqueryUi = require( "./lib/jquery-ui" ),
-	logger = require( "./lib/simple-log" ).init( "download.jqueryui.com" ),
 	Packager = require( "node-packager" ),
 	querystring = require( "querystring" ),
 	themeGallery = require( "./lib/themeroller-themegallery" )(),
@@ -76,7 +75,7 @@ Frontend.prototype = {
 			jqueryUi = JqueryUi.find( params.version );
 		}
 		if ( jqueryUi == null ) {
-			logger.error( "Invalid input \"version\" = \"" + params.version + "\"" );
+			console.error( "Invalid input \"version\" = \"" + params.version + "\"" );
 			data = { error: "invalid version" };
 		} else {
 			data = { categories: jqueryUi.categories };

lib/cache.js

@@ -1,7 +1,6 @@
 "use strict";
 
-var Cache, cacheCron, cacheCronTimeout, cacheExpiresTime, caches,
-	logger = require( "./simple-log" ).init( "download.jqueryui.com" );
+var Cache, cacheCron, cacheCronTimeout, cacheExpiresTime, caches;
 
 cacheExpiresTime = 0;
 caches = [];
@@ -22,7 +21,7 @@ cacheCron = function() {
 			}
 		} );
 
-		logger.log( cache.name + " Cleanup:", count );
+		console.log( cache.name + " Cleanup:", count );
 	} );
 	cacheCronTimeout = setTimeout( cacheCron, cacheExpiresTime );
 };

lib/simple-log.js

@@ -3,7 +3,6 @@
 var colorVars, textureVars, themeStaticCss,
 	async = require( "async" ),
 	Image = require( "./themeroller-image" ),
-	logger = require( "./simple-log" ).init( "download.jqueryui.com" ),
 	querystring = require( "querystring" ),
 	JqueryUi = require( "./jquery-ui" ),
 	semver = require( "semver" ),
@@ -351,7 +350,7 @@ ThemeRoller.prototype = {
 			var imageFiles = {};
 			if ( err ) {
 				err.message = "ThemeRoller#generateImages: " + err.message;
-				logger.error( err.message );
+				console.error( err.message );
 				callback( err );
 			} else {
 				results.forEach( function( file ) {

lib/themeroller.js

@@ -34,9 +34,6 @@
 		"winston": "^3.17.0",
 		"wolfy87-eventemitter": "5.2.9"
 	},
-	"optionalDependencies": {
-		"modern-syslog": "1.2.0"
-	},
 	"main": "main.js",
 	"scripts": {
 		"test": "qunit --require ./test/setup.js test"

package-lock.json

@@ -2,10 +2,8 @@
 
 "use strict";
 
-var logger = require( "./lib/simple-log" ).init( "download.jqueryui.com" );
-
 process.on( "uncaughtException", function( err ) {
-	logger.error( "Caught exception: " + ( err.stack || err ) );
+	console.error( "Caught exception: " + ( err.stack || err ) );
 	process.exit( 1 );
 } );
 
@@ -69,7 +67,7 @@ if ( !argv.nocache ) {
 // OBS: We were using an older version of connect, which lacked a descent way to centralize
 // requests error handling. We use express now but we haven't updated that code.
 function error( err, response ) {
-	logger.error( "User request exception: " + ( err.stack || err ) );
+	console.error( "User request exception: " + ( err.stack || err ) );
 	frontend.error( response );
 }