Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data race between appendEntry and FlushAndSync tsi1.(*LogFile) [port to 1.11] #25186

Closed
davidby-influx opened this issue Jul 23, 2024 · 0 comments · Fixed by #25243
Closed

Data race between appendEntry and FlushAndSync tsi1.(*LogFile) [port to 1.11] #25186

davidby-influx opened this issue Jul 23, 2024 · 0 comments · Fixed by #25243
Assignees
@davidby-influx
Labels
area/tsi kind/bug team/edge

Comments

@davidby-influx
Copy link
Contributor

Port #25181 to 1.11
@davidby-influx davidby-influx self-assigned this Jul 23, 2024
davidby-influx pushed a commit that referenced this issue Aug 12, 2024
@chengshiwen @davidby-influx
fix(tsi1): fix data race between appendEntry and FlushAndSync tsi1.(*…
62988e3 
…LogFile) (#25182)

Extend lock lifespan to encompass the
flushAndSync() call to avoid a race

closes #25181

(cherry picked from commit 7333da9)

closes #25186
@davidby-influx davidby-influx mentioned this issue Aug 12, 2024
Merged
@davidby-influx davidby-influx linked a pull request Aug 12, 2024 that will close this issue
fix(tsi1): fix data race between appendEntry and FlushAndSync tsi1.(*LogFile) (#25182) #25243
Merged
davidby-influx added a commit that referenced this issue Aug 13, 2024
@davidby-influx @chengshiwen
fix(tsi1): fix data race between appendEntry and FlushAndSync tsi1.(*…
1103783 
…LogFile) (#25182) (#25243)

Extend lock lifespan to encompass the
flushAndSync() call to avoid a race

closes #25181

(cherry picked from commit 7333da9)

closes #25186

Co-authored-by: Shiwen Cheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidby-influx davidby-influx

Labels
area/tsi kind/bug team/edge
Projects
None yet
Milestone
No milestone
1 participant
@davidby-influx