Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: html5lib/html5lib-tests
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: html5lib/html5lib-tests
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: sideshowbarker/preparsed-encoding-tests-add
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Aug 24, 2020

  1. Test the (meta) prescan algorithm 

    This change adds a `preparsed` subdirectory in the `encoding` directory,
with tests for which the result of the *encoding sniffing algorithm* at
https://html.spec.whatwg.org/#encoding-sniffing-algorithm is the
expected result — that is, tests for which the expected result is the
output of running *only* the encoding sniffing algorithm (of which the
main sub-algorithm is the so-called “meta prescan”) — without
also running the tokenization state machine and tree-construction stage.

This change also adds a README file that explicitly documents what the
expected results for the encoding tests are, based on whether or not
they’re in the `preparsed` subdirectory.

Without those changes, it’s unclear whether the expected results shown
in the existing tests are for the output of fully parsing the test data —
through the tokenization state machine and tree-construction stage — or
instead just the output of the encoding sniffing algorithm only. And
without those changes, we also don’t have any tests a system can use for
testing only the output from the encoding sniffing algorithm.

Fixes #28
    @sideshowbarker
    sideshowbarker committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    1e10bdb View commit details
    Browse the repository at this point in the history

  2. Note preparsed encoding tests are first 1024 bytes

    @sideshowbarker
    sideshowbarker committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    b6c4e3f View commit details
    Browse the repository at this point in the history
Loading