You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
should have the TODO highlighted as scope doctag, and used to, but no longer does as of d78749a (#3918).
Which language seems to have the issue?
bash
Are you using highlight or highlightAuto?
highlight
Sample Code to Reproduce
# This is a comment with a TODO item in it
Expected behavior TODO is highlighted as doctag scope.
Additional context
I upgraded highlight.js and this stopped working. I bisected the problem to d78749a (#3918); in particular the relevant problem seems to be somewhere in this code:
As far as I can tell, the scope: {2: 'comment'} is somehow screwing up the mode.contains.push({scope: 'doctag', ...}) detection in modes.js, but I don’t have a good enough grasp on highlight.js internals to really understand what's going on or how to fix it.
Describe the issue
# This is a comment with a TODO item in it
should have the
TODO
highlighted as scopedoctag
, and used to, but no longer does as of d78749a (#3918).Which language seems to have the issue?
bash
Are you using
highlight
orhighlightAuto
?highlight
Sample Code to Reproduce
# This is a comment with a TODO item in it
Expected behavior
TODO is highlighted as
doctag
scope.Additional context
I upgraded highlight.js and this stopped working. I bisected the problem to d78749a (#3918); in particular the relevant problem seems to be somewhere in this code:
highlight.js/src/languages/bash.js
Lines 41 to 52 in 85b2042
As far as I can tell, the
scope: {2: 'comment'}
is somehow screwing up themode.contains.push({scope: 'doctag', ...})
detection inmodes.js
, but I don’t have a good enough grasp on highlight.js internals to really understand what's going on or how to fix it.Test case which I expect to pass:
The text was updated successfully, but these errors were encountered: