Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(apache) continuation lines are not recognized #4157

Closed
bmarwell opened this issue Nov 1, 2024 · 3 comments · Fixed by #4158
Closed

(apache) continuation lines are not recognized #4157

bmarwell opened this issue Nov 1, 2024 · 3 comments · Fixed by #4158
Labels
bug help welcome Could use help from community language

Comments

@bmarwell
Copy link

bmarwell commented Nov 1, 2024

Describe the issue

Given this snippet:

<IfModule mod_deflate.c>
 AddOutputFilterByType DEFLATE "application/atom+xml" \
 "application/javascript" \
 "text/xml"
</IfModule>

The line continuation marks ( \) are not recogniezed. Everything following the first line ending with a continuation mark will not be highlighted correctly.

Which language seems to have the issue?
apache aka apacheconf

Are you using highlight or highlightAuto?

highlight="apache" in vue (but can reproduce on vanilla highlightjs)

Sample Code to Reproduce

See: https://jsfiddle.net/L52ndpkb/

Screenshot:

Screenshot 2024-11-01 at 11 36 13

Expected behavior

Same highlighting as without continuation lines:

Screenshot 2024-11-01 at 11 37 11

Additional context

./.

@joshgoebel
Copy link
Member

If you can build source you can try my fix.

@bmarwell
Copy link
Author

bmarwell commented Nov 1, 2024

Thanks, will try on Monday. Great response! I hope the description was clear and reproducible. I love the idea of including a fiddle link in the issue template, that was very helpful for documenting the reproducer. Great work! 👍🏻

@bmarwell
Copy link
Author

bmarwell commented Nov 4, 2024

Hi, I cannot build it myself, but as far as I can tell, the patch looks correct :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help welcome Could use help from community language
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants