Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_nm failing with nasm 2.16.03 #191

Closed
Tachi107 opened this issue Sep 1, 2024 · 2 comments
Closed

test_nm failing with nasm 2.16.03 #191

Tachi107 opened this issue Sep 1, 2024 · 2 comments

Comments

@Tachi107
Copy link
Contributor

Tachi107 commented Sep 1, 2024

Hi!

Debian recently upgraded to NASM version 2.16.03, and unfortunately this broke xbyak's test_nm.sh test. I'm not sure what broke exactly, so I'll just leave the error log here:

cxx=g++ ./test_nm.sh
nasm(32bit)
compile make_nm.cpp with -wall -i../ -dxbyak32
asm
xbyak
compile nm_frame.cpp
1045,1046c1045,1046
< 86d1
< 86c5
---
> 86ca
> 86e8
1048c1048
< 86f0
---
> 86c6
1053c1053
< 6687ce
---
> 6687f1
1061c1061
< 87f1
---
> 87ce

You may find some more information in the downstream bug report: https://bugs.debian.org/1080144.

What is the cause of this failure?

Thanks!

@herumi
Copy link
Owner

herumi commented Sep 2, 2024

It is because NASM has changed the bytecode output of xchg (bytecode execution is not affected).
Xbyak 7.07.1 follows the new behavior of NASM to pass the tests.
https://github.com/herumi/xbyak/blob/master/doc/changelog.md

@Tachi107
Copy link
Contributor Author

Tachi107 commented Sep 2, 2024

Thanks for the quick reply! This is indeed fixed when upgrading to the new release. Sorry for the noise!

@Tachi107 Tachi107 closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants