Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: grpc/grpc-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: grpc/grpc-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.66.x
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 47 files changed
  • 4 contributors

Commits on Jul 29, 2024

  1. Configuration menu
    Copy the full SHA
    c37fb18 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Revert "Introduce onResult2 in NameResolver Listener2 that returns St…

    …atus (#11313)" (#11423)
    
    This reverts commit 9ba2f9d.
    
    It causes a channel panic due to unimplemented onResult2().
    
    ```
    java.lang.UnsupportedOperationException: Not implemented.
            at io.grpc.NameResolver$Listener2.onResult2(NameResolver.java:257)
            at io.grpc.internal.DnsNameResolver$Resolve.lambda$run$0(DnsNameResolver.java:334)
            at io.grpc.SynchronizationContext.drain(SynchronizationContext.java:94)
            at io.grpc.SynchronizationContext.execute(SynchronizationContext.java:126)
    	at io.grpc.internal.DnsNameResolver$Resolve.run(DnsNameResolver.java:333)
    ```
    
    b/356669977
    ejona86 authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ef09d94 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Revert "Start 1.67.0 development cycle (#11416)" (#11428)

    This reverts commit 0090a52 since 1.67.0-SNAPSHOT should not be referenced in the 1.66.x release.
    kannanjgithub authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    752a045 View commit details
    Browse the repository at this point in the history
  2. xds: XdsClient should unsubscribe on last resource (#11264)

    Otherwise, the server will continue sending updates and if we
    re-subscribe to the last resource, the server won't re-send it. Also
    completely remove the per-type state, as it could only add confusion.
    lujiajing1126 authored and ejona86 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    19c9b99 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Configuration menu
    Copy the full SHA
    33af0a7 View commit details
    Browse the repository at this point in the history
  2. Bump version to 1.66.0

    kannanjgithub committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    cf78406 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a9749ba View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Configuration menu
    Copy the full SHA
    5a5ef2a View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Configuration menu
    Copy the full SHA
    fb4e486 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. core: touch() buffer when detach()ing

    Detachable lets a buffer outlive its original lifetime. The new lifetime
    is application-controlled. If the application fails to read/close the
    stream, then the leak detector wouldn't make clear what code was
    responsible for the buffer's lifetime. With this touch, we'll be able to
    see detach() was called and thus know the application needs debugging.
    
    Realized when looking at b/364531464, although I think the issue is
    unrelated.
    ejona86 committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    81cc82e View commit details
    Browse the repository at this point in the history
Loading