Skip to content

Commit ff8e413

Browse files
authored
Remove direct dependency on j2objc
Bazel had the dependency added because of #5046, where Guava was depending on it as compile-only and Bazel build have "unknown enum constant" warnings. Guava now has a compile dependency on j2objc, so this workaround is no longer needed. There are currently no version skew issues in Gradle, which was the only usage.
1 parent 909c4bc commit ff8e413

File tree

19 files changed

+11
-22
lines changed

19 files changed

+11
-22
lines changed

alts/BUILD.bazel

-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ java_library(
1919
"@com_google_protobuf//:protobuf_java_util",
2020
artifact("com.google.code.findbugs:jsr305"),
2121
artifact("com.google.guava:guava"),
22-
artifact("com.google.j2objc:j2objc-annotations"),
2322
artifact("io.netty:netty-buffer"),
2423
artifact("io.netty:netty-codec"),
2524
artifact("io.netty:netty-common"),
@@ -45,7 +44,6 @@ java_library(
4544
artifact("com.google.auth:google-auth-library-oauth2-http"),
4645
artifact("com.google.code.findbugs:jsr305"),
4746
artifact("com.google.guava:guava"),
48-
artifact("com.google.j2objc:j2objc-annotations"),
4947
artifact("io.netty:netty-common"),
5048
artifact("io.netty:netty-handler"),
5149
artifact("io.netty:netty-transport"),

api/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,5 @@ java_library(
1313
artifact("com.google.errorprone:error_prone_annotations"),
1414
artifact("com.google.guava:failureaccess"), # future transitive dep of Guava. See #5214
1515
artifact("com.google.guava:guava"),
16-
artifact("com.google.j2objc:j2objc-annotations"),
1716
],
1817
)

auth/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,5 @@ java_library(
1111
artifact("com.google.auth:google-auth-library-credentials"),
1212
artifact("com.google.code.findbugs:jsr305"),
1313
artifact("com.google.guava:guava"),
14-
artifact("com.google.j2objc:j2objc-annotations"),
1514
],
1615
)

core/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ java_library(
3030
artifact("com.google.code.findbugs:jsr305"),
3131
artifact("com.google.errorprone:error_prone_annotations"),
3232
artifact("com.google.guava:guava"),
33-
artifact("com.google.j2objc:j2objc-annotations"),
3433
artifact("io.perfmark:perfmark-api"),
3534
artifact("org.codehaus.mojo:animal-sniffer-annotations"),
3635
],

examples/pom.xml

+5
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,11 @@
5555
<artifactId>protobuf-java-util</artifactId>
5656
<version>${protobuf.version}</version>
5757
</dependency>
58+
<dependency> <!-- Use newer version than in protobuf-java-util -->
59+
<groupId>com.google.j2objc</groupId>
60+
<artifactId>j2objc-annotations</artifactId>
61+
<version>3.0.0</version>
62+
</dependency>
5863
<dependency>
5964
<groupId>org.apache.tomcat</groupId>
6065
<artifactId>annotations-api</artifactId>

gcp-observability/build.gradle

+1-2
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,7 @@ dependencies {
6565
libraries.auto.value.annotations, // Use our newer version
6666
libraries.guava.jre, // Use our newer version
6767
libraries.protobuf.java.util, // Use our newer version
68-
libraries.re2j, // Use our newer version
69-
libraries.j2objc.annotations // Explicit dependency to keep in step with version used by guava
68+
libraries.re2j // Use our newer version
7069

7170
testImplementation testFixtures(project(':grpc-api')),
7271
project(':grpc-testing'),

gradle/libs.versions.toml

-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ guava-testlib = "com.google.guava:guava-testlib:33.2.1-android"
4242
# May be different from the -android version.
4343
guava-jre = "com.google.guava:guava:33.2.1-jre"
4444
hdrhistogram = "org.hdrhistogram:HdrHistogram:2.2.2"
45-
j2objc-annotations = " com.google.j2objc:j2objc-annotations:3.0.0"
4645
jakarta-servlet-api = "jakarta.servlet:jakarta.servlet-api:5.0.0"
4746
javax-annotation = "org.apache.tomcat:annotations-api:6.0.53"
4847
javax-servlet-api = "javax.servlet:javax.servlet-api:4.0.1"

grpclb/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ java_library(
2121
"@io_grpc_grpc_proto//:grpclb_load_balancer_java_proto",
2222
artifact("com.google.code.findbugs:jsr305"),
2323
artifact("com.google.guava:guava"),
24-
artifact("com.google.j2objc:j2objc-annotations"),
2524
],
2625
)
2726

grpclb/build.gradle

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ dependencies {
1919
implementation project(':grpc-core'),
2020
project(':grpc-protobuf'),
2121
project(':grpc-stub'),
22+
libraries.guava,
2223
libraries.protobuf.java,
23-
libraries.protobuf.java.util,
24-
libraries.guava
24+
libraries.protobuf.java.util
2525
runtimeOnly libraries.errorprone.annotations
2626
compileOnly libraries.javax.annotation
2727
testImplementation libraries.truth,

inprocess/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,5 @@ java_library(
1313
artifact("com.google.code.findbugs:jsr305"),
1414
artifact("com.google.errorprone:error_prone_annotations"),
1515
artifact("com.google.guava:guava"),
16-
artifact("com.google.j2objc:j2objc-annotations"),
1716
],
1817
)

netty/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ java_library(
1515
artifact("com.google.code.findbugs:jsr305"),
1616
artifact("com.google.errorprone:error_prone_annotations"),
1717
artifact("com.google.guava:guava"),
18-
artifact("com.google.j2objc:j2objc-annotations"),
1918
artifact("io.netty:netty-buffer"),
2019
artifact("io.netty:netty-codec"),
2120
artifact("io.netty:netty-codec-http"),

okhttp/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ java_library(
1717
artifact("com.google.code.findbugs:jsr305"),
1818
artifact("com.google.errorprone:error_prone_annotations"),
1919
artifact("com.google.guava:guava"),
20-
artifact("com.google.j2objc:j2objc-annotations"),
2120
artifact("com.squareup.okhttp:okhttp"),
2221
artifact("com.squareup.okio:okio"),
2322
artifact("io.perfmark:perfmark-api"),

protobuf-lite/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ java_library(
1010
"//api",
1111
artifact("com.google.code.findbugs:jsr305"),
1212
artifact("com.google.guava:guava"),
13-
artifact("com.google.j2objc:j2objc-annotations"),
1413
] + select({
1514
":android": ["@com_google_protobuf//:protobuf_javalite"],
1615
"//conditions:default": ["@com_google_protobuf//:protobuf_java"],

protobuf/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,5 @@ java_library(
1313
artifact("com.google.api.grpc:proto-google-common-protos"),
1414
artifact("com.google.code.findbugs:jsr305"),
1515
artifact("com.google.guava:guava"),
16-
artifact("com.google.j2objc:j2objc-annotations"),
1716
],
1817
)

services/build.gradle

+2-3
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,10 @@ dependencies {
2727
implementation project(':grpc-core'),
2828
project(':grpc-protobuf'),
2929
project(':grpc-util'),
30-
libraries.protobuf.java.util,
31-
libraries.guava.jre // JRE required by protobuf-java-util
30+
libraries.guava.jre, // JRE required by protobuf-java-util
31+
libraries.protobuf.java.util
3232

3333
runtimeOnly libraries.errorprone.annotations,
34-
libraries.j2objc.annotations, // Explicit dependency to keep in step with version used by guava
3534
libraries.gson // to fix checkUpperBoundDeps error here
3635
compileOnly libraries.javax.annotation
3736
testImplementation project(':grpc-testing'),

stub/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ java_library(
1212
artifact("com.google.code.findbugs:jsr305"),
1313
artifact("com.google.errorprone:error_prone_annotations"),
1414
artifact("com.google.guava:guava"),
15-
artifact("com.google.j2objc:j2objc-annotations"),
1615
],
1716
)
1817

testing/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ java_library(
1818
"//util",
1919
artifact("com.google.code.findbugs:jsr305"),
2020
artifact("com.google.guava:guava"),
21-
artifact("com.google.j2objc:j2objc-annotations"),
2221
artifact("com.google.truth:truth"),
2322
artifact("junit:junit"),
2423
],

util/BUILD.bazel

-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ java_library(
1515
artifact("com.google.code.findbugs:jsr305"),
1616
artifact("com.google.errorprone:error_prone_annotations"),
1717
artifact("com.google.guava:guava"),
18-
artifact("com.google.j2objc:j2objc-annotations"),
1918
artifact("org.codehaus.mojo:animal-sniffer-annotations"),
2019
],
2120
)

xds/build.gradle

+1
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ dependencies {
5252
project(':grpc-services'),
5353
project(':grpc-auth'),
5454
project(path: ':grpc-alts', configuration: 'shadow'),
55+
libraries.guava,
5556
libraries.gson,
5657
libraries.re2j,
5758
libraries.auto.value.annotations,

0 commit comments

Comments
 (0)