api,protobuf-lite: solve code style issues

Author: manuelkollus

api/src/main/java/io/grpc/Attributes.java

@@ -252,7 +252,7 @@ public <T> Builder discard(Key<T> key) {
       return this;
     }
 
-    public <T> Builder setAll(Attributes other) {
+    public Builder setAll(Attributes other) {
       data(other.data.size()).putAll(other.data);
       return this;
     }

api/src/main/java/io/grpc/InternalMethodDescriptor.java

@@ -30,11 +30,11 @@ public InternalMethodDescriptor(InternalKnownTransport transport) {
     this.transport = checkNotNull(transport, "transport");
   }
 
-  public Object geRawMethodName(MethodDescriptor<?, ?> md) {
-    return md.getRawMethodName(transport.ordinal());
+  public Object geRawMethodName(MethodDescriptor<?, ?> descriptor) {
+    return descriptor.getRawMethodName(transport.ordinal());
   }
 
-  public void setRawMethodName(MethodDescriptor<?, ?> md, Object o) {
-    md.setRawMethodName(transport.ordinal(), o);
+  public void setRawMethodName(MethodDescriptor<?, ?> descriptor, Object o) {
+    descriptor.setRawMethodName(transport.ordinal(), o);
   }
 }

api/src/main/java/io/grpc/NameResolverRegistry.java

@@ -86,8 +86,8 @@ private synchronized void refreshProviders() {
     // sort() must be stable, as we prefer first-registered providers
     Collections.sort(providers, Collections.reverseOrder(new Comparator<NameResolverProvider>() {
       @Override
-      public int compare(NameResolverProvider p1, NameResolverProvider p2) {
-        return p1.priority() - p2.priority();
+      public int compare(NameResolverProvider o1, NameResolverProvider o2) {
+        return o1.priority() - o2.priority();
       }
     }));
     effectiveProviders = Collections.unmodifiableList(providers);

protobuf-lite/src/main/java/io/grpc/protobuf/lite/ProtoLiteUtils.java

@@ -97,8 +97,8 @@ public static <T extends MessageLite> Metadata.BinaryMarshaller<T> metadataMarsh
   /** Copies the data from input stream to output stream. */
   static long copy(InputStream from, OutputStream to) throws IOException {
     // Copied from guava com.google.common.io.ByteStreams because its API is unstable (beta)
-    checkNotNull(from);
-    checkNotNull(to);
+    checkNotNull(from, "inputStream cannot be null!");
+    checkNotNull(to, "outputStream cannot be null!");
     byte[] buf = new byte[BUF_SIZE];
     long total = 0;
     while (true) {
@@ -162,7 +162,7 @@ public T parse(InputStream stream) {
             @SuppressWarnings("unchecked")
             T message = (T) ((ProtoInputStream) stream).message();
             return message;
-          } catch (IllegalStateException ex) {
+          } catch (IllegalStateException ignored) {
             // Stream must have been read from, which is a strange state. Since the point of this
             // optimization is to be transparent, instead of throwing an error we'll continue,
             // even though it seems likely there's a bug.