Skip to content

Commit ddb16c5

Browse files
committed
Upgrade Guava to 26.0-android
This reverts commit 4adcf24. The downgrade of Guava has gone out in a release, so we can upgrade it again in the next release.
1 parent 7238516 commit ddb16c5

File tree

7 files changed

+19
-24
lines changed

7 files changed

+19
-24
lines changed

alts/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ dependencies {
2929
compile (libraries.google_auth_oauth2_http) {
3030
// prefer 3.0.2 from libraries instead of 1.3.9
3131
exclude group: 'com.google.code.findbugs', module: 'jsr305'
32-
// prefer 25.1 from libraries instead of 19.0
32+
// prefer 20.0 from libraries instead of 19.0
3333
exclude group: 'com.google.guava', module: 'guava'
3434
}
3535
compileOnly libraries.javax_annotation

build.gradle

+1-4
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,7 @@ subprojects {
109109

110110
nettyVersion = '4.1.32.Final'
111111
googleauthVersion = '0.9.0'
112-
// Temporarily use a slightly older version of Guava. Will want to bump
113-
// to 27.0.1+ with grpc 1.19 or 1.20 for the listenablefuture dep changes.
114-
guavaVersion = '25.1-android'
112+
guavaVersion = '26.0-android'
115113
protobufVersion = '3.5.1'
116114
protocVersion = '3.5.1-1'
117115
protobufNanoVersion = '3.0.0-alpha-5'
@@ -196,7 +194,6 @@ subprojects {
196194
}
197195
libraries = [
198196
animalsniffer_annotations: "org.codehaus.mojo:animal-sniffer-annotations:1.17",
199-
checker_compat_qual: "org.checkerframework:checker-compat-qual:2.5.2",
200197
errorprone: "com.google.errorprone:error_prone_annotations:2.2.0",
201198
gson: "com.google.code.gson:gson:2.7",
202199
guava: "com.google.guava:guava:${guavaVersion}",

core/build.gradle

+9-5
Original file line numberDiff line numberDiff line change
@@ -6,24 +6,28 @@ dependencies {
66
libraries.errorprone,
77
libraries.jsr305,
88
libraries.animalsniffer_annotations
9-
// Brought in by Guava, but Proguard fails with 2.0.0. So we bump it to 2.5.2
10-
compile libraries.checker_compat_qual
119
compile (libraries.guava) {
1210
// prefer 2.2.0 from libraries instead of 2.1.3
1311
exclude group: 'com.google.errorprone', module: 'error_prone_annotations'
14-
// prefer 2.5.2 from libraries instead of 2.0.0
15-
exclude group: 'org.checkerframework', module: 'checker-compat-qual'
12+
// prefer 3.0.2 from libraries instead of 3.0.1
13+
exclude group: 'com.google.code.findbugs', module: 'jsr305'
1614
// prefer 1.17 from libraries instead of 1.14
1715
exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations'
1816
}
1917
compile (libraries.opencensus_api) {
18+
// prefer 3.0.2 from libraries instead of 3.0.1
19+
exclude group: 'com.google.code.findbugs', module: 'jsr305'
20+
// prefer 20.0 from libraries instead of 19.0
21+
exclude group: 'com.google.guava', module: 'guava'
2022
// we'll always be more up-to-date
2123
exclude group: 'io.grpc', module: 'grpc-context'
2224
}
2325
compile (libraries.opencensus_contrib_grpc_metrics) {
26+
// prefer 3.0.2 from libraries instead of 3.0.1
27+
exclude group: 'com.google.code.findbugs', module: 'jsr305'
2428
// we'll always be more up-to-date
2529
exclude group: 'io.grpc', module: 'grpc-context'
26-
// prefer 25.1 from libraries instead of 20.0
30+
// prefer 20.0 from libraries instead of 19.0
2731
exclude group: 'com.google.guava', module: 'guava'
2832
}
2933

protobuf-lite/build.gradle

+2-4
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,11 @@ description = 'gRPC: Protobuf Lite'
1414
dependencies {
1515
compile project(':grpc-core'),
1616
libraries.protobuf_lite
17-
// Brought in by Guava, but Proguard fails with 2.0.0. So we bump it to 2.5.2
18-
compile libraries.checker_compat_qual
1917
compile (libraries.guava) {
2018
// prefer 2.2.0 from libraries instead of 2.1.3
2119
exclude group: 'com.google.errorprone', module: 'error_prone_annotations'
22-
// prefer 2.5.2 from libraries instead of 2.0.0
23-
exclude group: 'org.checkerframework', module: 'checker-compat-qual'
20+
// prefer 3.0.2 from libraries instead of 3.0.1
21+
exclude group: 'com.google.code.findbugs', module: 'jsr305'
2422
// prefer 1.17 from libraries instead of 1.14
2523
exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations'
2624
}

protobuf-nano/build.gradle

+2-4
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,11 @@ description = 'gRPC: Protobuf Nano'
1212
dependencies {
1313
compile project(':grpc-core'),
1414
libraries.protobuf_nano
15-
// Brought in by Guava, but Proguard fails with 2.0.0. So we bump it to 2.5.2
16-
compile libraries.checker_compat_qual
1715
compile (libraries.guava) {
1816
// prefer 2.2.0 from libraries instead of 2.1.3
1917
exclude group: 'com.google.errorprone', module: 'error_prone_annotations'
20-
// prefer 2.5.2 from libraries instead of 2.0.0
21-
exclude group: 'org.checkerframework', module: 'checker-compat-qual'
18+
// prefer 3.0.2 from libraries instead of 3.0.1
19+
exclude group: 'com.google.code.findbugs', module: 'jsr305'
2220
// prefer 1.17 from libraries instead of 1.14
2321
exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations'
2422
}

protobuf/build.gradle

+2-4
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,11 @@ buildscript {
1111
dependencies {
1212
compile project(':grpc-core'),
1313
libraries.protobuf
14-
// Brought in by Guava, but Proguard fails with 2.0.0. So we bump it to 2.5.2
15-
compile libraries.checker_compat_qual
1614
compile (libraries.guava) {
1715
// prefer 2.2.0 from libraries instead of 2.1.3
1816
exclude group: 'com.google.errorprone', module: 'error_prone_annotations'
19-
// prefer 2.5.2 from libraries instead of 2.0.0
20-
exclude group: 'org.checkerframework', module: 'checker-compat-qual'
17+
// prefer 3.0.2 from libraries instead of 3.0.1
18+
exclude group: 'com.google.code.findbugs', module: 'jsr305'
2119
// prefer 1.17 from libraries instead of 1.14
2220
exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations'
2321
}

repositories.bzl

+2-2
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,8 @@ def com_google_errorprone_error_prone_annotations():
158158
def com_google_guava():
159159
native.maven_jar(
160160
name = "com_google_guava_guava",
161-
artifact = "com.google.guava:guava:25.1-android",
162-
sha1 = "bdaab946ca5ad20253502d873ba0c3313d141036",
161+
artifact = "com.google.guava:guava:26.0-android",
162+
sha1 = "ef69663836b339db335fde0df06fb3cd84e3742b",
163163
)
164164

165165
def com_google_j2objc_j2objc_annotations():

0 commit comments

Comments
 (0)