Skip to content

Commit 4adcf24

Browse files
authored
Downgrade to Guava 25.1
This is temporary for the 1.18 release to give users a bit more time to get past the breaking changes to Beta APIs in Guava 26. Fixes #5166
1 parent e74576b commit 4adcf24

File tree

7 files changed

+24
-19
lines changed

7 files changed

+24
-19
lines changed

alts/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ dependencies {
2929
compile (libraries.google_auth_oauth2_http) {
3030
// prefer 3.0.2 from libraries instead of 1.3.9
3131
exclude group: 'com.google.code.findbugs', module: 'jsr305'
32-
// prefer 20.0 from libraries instead of 19.0
32+
// prefer 25.1 from libraries instead of 19.0
3333
exclude group: 'com.google.guava', module: 'guava'
3434
}
3535
compileOnly libraries.javax_annotation

build.gradle

+4-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,9 @@ subprojects {
107107

108108
nettyVersion = '4.1.32.Final'
109109
googleauthVersion = '0.9.0'
110-
guavaVersion = '26.0-android'
110+
// Temporarily use a slightly older version of Guava. Will want to bump
111+
// to 27.0.1+ with grpc 1.19 or 1.20 for the listenablefuture dep changes.
112+
guavaVersion = '25.1-android'
111113
protobufVersion = '3.5.1'
112114
protocVersion = '3.5.1-1'
113115
protobufNanoVersion = '3.0.0-alpha-5'
@@ -192,6 +194,7 @@ subprojects {
192194
}
193195
libraries = [
194196
animalsniffer_annotations: "org.codehaus.mojo:animal-sniffer-annotations:1.17",
197+
checker_compat_qual: "org.checkerframework:checker-compat-qual:2.5.2",
195198
errorprone: "com.google.errorprone:error_prone_annotations:2.2.0",
196199
gson: "com.google.code.gson:gson:2.7",
197200
guava: "com.google.guava:guava:${guavaVersion}",

core/build.gradle

+5-9
Original file line numberDiff line numberDiff line change
@@ -6,28 +6,24 @@ dependencies {
66
libraries.errorprone,
77
libraries.jsr305,
88
libraries.animalsniffer_annotations
9+
// Brought in by Guava, but Proguard fails with 2.0.0. So we bump it to 2.5.2
10+
compile libraries.checker_compat_qual
911
compile (libraries.guava) {
1012
// prefer 2.2.0 from libraries instead of 2.1.3
1113
exclude group: 'com.google.errorprone', module: 'error_prone_annotations'
12-
// prefer 3.0.2 from libraries instead of 3.0.1
13-
exclude group: 'com.google.code.findbugs', module: 'jsr305'
14+
// prefer 2.5.2 from libraries instead of 2.0.0
15+
exclude group: 'org.checkerframework', module: 'checker-compat-qual'
1416
// prefer 1.17 from libraries instead of 1.14
1517
exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations'
1618
}
1719
compile (libraries.opencensus_api) {
18-
// prefer 3.0.2 from libraries instead of 3.0.1
19-
exclude group: 'com.google.code.findbugs', module: 'jsr305'
20-
// prefer 20.0 from libraries instead of 19.0
21-
exclude group: 'com.google.guava', module: 'guava'
2220
// we'll always be more up-to-date
2321
exclude group: 'io.grpc', module: 'grpc-context'
2422
}
2523
compile (libraries.opencensus_contrib_grpc_metrics) {
26-
// prefer 3.0.2 from libraries instead of 3.0.1
27-
exclude group: 'com.google.code.findbugs', module: 'jsr305'
2824
// we'll always be more up-to-date
2925
exclude group: 'io.grpc', module: 'grpc-context'
30-
// prefer 20.0 from libraries instead of 19.0
26+
// prefer 25.1 from libraries instead of 20.0
3127
exclude group: 'com.google.guava', module: 'guava'
3228
}
3329

protobuf-lite/build.gradle

+4-2
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,13 @@ description = 'gRPC: Protobuf Lite'
1414
dependencies {
1515
compile project(':grpc-core'),
1616
libraries.protobuf_lite
17+
// Brought in by Guava, but Proguard fails with 2.0.0. So we bump it to 2.5.2
18+
compile libraries.checker_compat_qual
1719
compile (libraries.guava) {
1820
// prefer 2.2.0 from libraries instead of 2.1.3
1921
exclude group: 'com.google.errorprone', module: 'error_prone_annotations'
20-
// prefer 3.0.2 from libraries instead of 3.0.1
21-
exclude group: 'com.google.code.findbugs', module: 'jsr305'
22+
// prefer 2.5.2 from libraries instead of 2.0.0
23+
exclude group: 'org.checkerframework', module: 'checker-compat-qual'
2224
// prefer 1.17 from libraries instead of 1.14
2325
exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations'
2426
}

protobuf-nano/build.gradle

+4-2
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,13 @@ description = 'gRPC: Protobuf Nano'
1212
dependencies {
1313
compile project(':grpc-core'),
1414
libraries.protobuf_nano
15+
// Brought in by Guava, but Proguard fails with 2.0.0. So we bump it to 2.5.2
16+
compile libraries.checker_compat_qual
1517
compile (libraries.guava) {
1618
// prefer 2.2.0 from libraries instead of 2.1.3
1719
exclude group: 'com.google.errorprone', module: 'error_prone_annotations'
18-
// prefer 3.0.2 from libraries instead of 3.0.1
19-
exclude group: 'com.google.code.findbugs', module: 'jsr305'
20+
// prefer 2.5.2 from libraries instead of 2.0.0
21+
exclude group: 'org.checkerframework', module: 'checker-compat-qual'
2022
// prefer 1.17 from libraries instead of 1.14
2123
exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations'
2224
}

protobuf/build.gradle

+4-2
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,13 @@ buildscript {
1111
dependencies {
1212
compile project(':grpc-core'),
1313
libraries.protobuf
14+
// Brought in by Guava, but Proguard fails with 2.0.0. So we bump it to 2.5.2
15+
compile libraries.checker_compat_qual
1416
compile (libraries.guava) {
1517
// prefer 2.2.0 from libraries instead of 2.1.3
1618
exclude group: 'com.google.errorprone', module: 'error_prone_annotations'
17-
// prefer 3.0.2 from libraries instead of 3.0.1
18-
exclude group: 'com.google.code.findbugs', module: 'jsr305'
19+
// prefer 2.5.2 from libraries instead of 2.0.0
20+
exclude group: 'org.checkerframework', module: 'checker-compat-qual'
1921
// prefer 1.17 from libraries instead of 1.14
2022
exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations'
2123
}

repositories.bzl

+2-2
Original file line numberDiff line numberDiff line change
@@ -158,8 +158,8 @@ def com_google_errorprone_error_prone_annotations():
158158
def com_google_guava():
159159
native.maven_jar(
160160
name = "com_google_guava_guava",
161-
artifact = "com.google.guava:guava:26.0-android",
162-
sha1 = "ef69663836b339db335fde0df06fb3cd84e3742b",
161+
artifact = "com.google.guava:guava:25.1-android",
162+
sha1 = "bdaab946ca5ad20253502d873ba0c3313d141036",
163163
)
164164

165165
def com_google_j2objc_j2objc_annotations():

0 commit comments

Comments
 (0)