Expose credentials.NewRequestInfoContext as a public (experimental) API #8080
Comments
|
Hey @vadimsht , thank you for your suggestion regarding making credentials.NewRequestInfoContext public. |
|
Hi! Any updates? |
|
Hey @vadimsht , I had a discussion with other maintainers and we have agreed to make it externally available. Though it might take some time before we get to it. I will keep this issue open to track the progress. |
|
Hey @vadimsht , it might take some time before we can get to this, but if you are blocked in the mean time , you can raise a PR for the same and we will review it. But we will need to make sure that it doesn't impact the readability of the documentation for the most common use cases. Also , please do verify if only exporting this solves your use case locally. Let me know if you are open to taking it up. |
|
This issue is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
|
I'll prepare a PR. |
|
I verified this PR is enough to unblock my use case: https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/6387979 |
|
This issue is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
Use case(s) - what problem will this feature solve?
We have a Go library that reuses gRPC code generator and many of APIs, but uses an alternative transport layer (simple HTTP request/responses): http://go.chromium.org/luci/grpc/prpc The can historically be traced to lack of HTTP2 support on Google Appengine and it solves the same problem as solved by grpc-web proxy, except without a proxy.
We are morphing this library to be closer and closer to the real gRPC client, to do a full switch at some point.
As part of that, it would be nice to be able to use PerRPCCredentials. Unfortunately, many implementations of this interface call
credentials.RequestInfoFromContext(ctx)to check the security level etc. And this is impossible to setup without access to internal https://pkg.go.dev/google.golang.org/grpc/internal/credentials#NewRequestInfoContextProposed Solution
Please consider making this API public. This will also likely help with unit-testing PerRPCCredentials implementations.
The text was updated successfully, but these errors were encountered: