Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constant for OpenStreetMap URL #102

Open
xamanu opened this issue Dec 15, 2017 · 2 comments
Open

Constant for OpenStreetMap URL #102

xamanu opened this issue Dec 15, 2017 · 2 comments
Labels
enhancement help wanted

Comments

@xamanu
Copy link
Contributor

xamanu commented Dec 15, 2017

Currently we are using hardcoded urls in every status/warning/error message to OpenStreetMap https://osm.org/. @ialokim suggests in #99 (comment):

we should use an static variable to not hardcode the same url over and over again
@xamanu
Copy link
Contributor Author

xamanu commented Dec 15, 2017

Using a static variable or a global constant and how to handle those concepts in Python is not completely clear to me. A quick research got me to the point, that we probably will need some kind of const class, which could bring a lot of good opportunities.

@xamanu xamanu mentioned this issue Dec 15, 2017
Merged
@xamanu
Copy link
Contributor Author

xamanu commented Apr 4, 2018

@grote do you think a "const class" is the right way to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xamanu