Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better observability for subscriptions #1439

Closed
lutter opened this issue Jan 8, 2020 · 1 comment
Closed

Better observability for subscriptions #1439

lutter opened this issue Jan 8, 2020 · 1 comment

Comments

@lutter
Copy link
Collaborator

lutter commented Jan 8, 2020

We need to gather better metrics for the steps we take from updating a subgraph to sending out an update for any subscriptions for that subgraph. For that, we should

  • Add a timestamp to StoreEvent that gets set when the event is created
  • Add Prometheus metrics that measure time since event creation at the following points when handling StoreEvents (ideally per subgraph):
    • StoreEvent is sent (i.e., NOTIFY is called)
    • StoreEvent is received in store::postgres::NotificationListener
    • StoreEvent is received in the GraphQL layer in graphql::subscription::execute_subscription_event
    • Subscription update is sent in server::websocket::connection::handle_incoming_message by putting it into the result_sink This last step will require that the timestamp of the StoreEvent is returned in the response stream together with the actual query result

For each step in the process we'd want to define how much processing time is acceptable, and bin Prometheus values accordingly. Some work needs to go into understanding what realistic values for these are.

@lutter
Copy link
Collaborator Author

lutter commented Apr 6, 2025

Subscriptions are no longer supported

@lutter lutter closed this as completed Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants