Skip to content

Proposal: Add goimports support to Playground (add/remove stdlib imports on Format). #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmitshur opened this issue Jul 19, 2015 · 3 comments

Comments

@dmitshur
Copy link
Member

The Go Playground has a checkbox to enable goimports-like fixing imports when pressing Format.

image

It's handy for fixing imports of standard library (fmt, io, bytes, etc.), and I'm used to it. I'd like to see it added to GopherJS Playground to make it better.

Any thoughts? Objections?

Should it be optional like on Go Playground or just always on?

I can volunteer to implement it. I already have implemented it locally, so it's just a matter of cleaning up the code and making a PR.

@dominikh
Copy link
Member

If we're going to add it, make it optional please.

@dmitshur
Copy link
Member Author

Ok. Is it ok for it to be on by default? I think on average more people would benefit from having it on rather than off.

@dmitshur
Copy link
Member Author

+1 from me, I want this feature.

I may make a PR for it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants