Skip to content

GopherJS Playground sharing uses suboptimal URL. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmitshur opened this issue Jan 10, 2015 · 1 comment · Fixed by #15
Closed

GopherJS Playground sharing uses suboptimal URL. #14

dmitshur opened this issue Jan 10, 2015 · 1 comment · Fixed by #15

Comments

@dmitshur
Copy link
Member

The playground that you see at http://gopherjs.org/play/ is actually inside an iframe pointing to http://gopherjs.org/playground/index.html.

But the code uses the current frame's URL to generate the shared link.

So, sharing kinda works, but the generated link has the form of:

http://gopherjs.org/playground/index.html#/Myqj0bQVev

Which takes you out of the iframe with the nicer URL. And http://gopherjs.org/play/#/Myqj0bQVev does not work because it doesn't read the URL of the parent frame.

@dmitshur
Copy link
Member Author

Fixed! \o/

http://gopherjs.org/play/#/Myqj0bQVev now works! And sharing produces the same form of URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant