Skip to content

Commit 4d84021

Browse files
alexandeartatianab
authored andcommitted
internal/database: replace os.MkdirTemp with T.TempDir
Updates [#45402](https://go.dev/issue/45402). Change-Id: I7e14a6923af21fd5ce4979c648734155a3468558 GitHub-Last-Rev: 81004b2 GitHub-Pull-Request: #1508 Reviewed-on: https://go-review.googlesource.com/c/vulndb/+/463098 Reviewed-by: Tatiana Bradley <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Tim King <[email protected]> Reviewed-by: Tim King <[email protected]>
1 parent 0f90384 commit 4d84021

File tree

1 file changed

+3
-22
lines changed

1 file changed

+3
-22
lines changed

internal/database/write_test.go

+3-22
Original file line numberDiff line numberDiff line change
@@ -6,30 +6,20 @@ package database
66

77
import (
88
"fmt"
9-
"os"
109
"testing"
1110

1211
"github.com/google/go-cmp/cmp"
1312
"golang.org/x/mod/sumdb/dirhash"
1413
)
1514

1615
func TestWrite(t *testing.T) {
17-
tempDir, err := os.MkdirTemp("", "testWrite")
18-
if err != nil {
19-
t.Fatal(err)
20-
}
21-
22-
defer func() {
23-
if err := os.RemoveAll(tempDir); err != nil {
24-
t.Log(err)
25-
}
26-
}()
16+
tempDir := t.TempDir()
2717

2818
if err := valid.Write(tempDir, true); err != nil {
2919
t.Fatal(err)
3020
}
3121

32-
if err = cmpDirHashes(tempDir, validDir); err != nil {
22+
if err := cmpDirHashes(tempDir, validDir); err != nil {
3323
t.Error(err)
3424
}
3525
}
@@ -53,16 +43,7 @@ func cmpDirHashes(d1, d2 string) error {
5343

5444
// Check that Write and Load are inverses.
5545
func TestWriteLoad(t *testing.T) {
56-
tempDir, err := os.MkdirTemp("", "testWriteLoad")
57-
if err != nil {
58-
t.Fatal(err)
59-
}
60-
61-
defer func() {
62-
if err := os.RemoveAll(tempDir); err != nil {
63-
t.Log(err)
64-
}
65-
}()
46+
tempDir := t.TempDir()
6647

6748
written := valid
6849
if err := written.Write(tempDir, false); err != nil {

0 commit comments

Comments
 (0)