Skip to content

Commit 726029b

Browse files
h9jianggopherbot
authored andcommitted
build: surface error when noticing test failure
'set -e' means exit immediately on error. Previously, the presubmit from integration test may experience false positive because the exit code from npm test is not being captured. This false positive is noticed in CL 649258 where kokoro test failed but LUCI test passed. This CL should fail due to go1.24 vet behavior change but should pass if rebased CL 649475. For #3533 Change-Id: Iee7d5d02c178b8655a81b088f914d65237f79834 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/649635 Auto-Submit: Hongxiang Jiang <[email protected]> Reviewed-by: Robert Findley <[email protected]> kokoro-CI: kokoro <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent 20da28f commit 726029b

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

build/integration_test.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,9 @@ func TestIntegration(t *testing.T) {
4848
// Use "npm config set color false" to disable npm color output globally,
4949
// and because we cannot access the Mocha command directly in this script,
5050
// we use env "FORCE_COLOR=0" to disable its color output.
51-
script := `npm config set color false;
51+
script := `set -e;
52+
53+
npm config set color false;
5254
npm ci;
5355
5456
echo "**** Set up virtual display ****";

0 commit comments

Comments
 (0)