Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/exec: ocassional fork/exec failures with "The parameter is incorrect." on Windows #73170

Closed
gopherbot opened this issue Apr 4, 2025 · 5 comments
Assignees
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker
Milestone

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Apr 4, 2025

#!watchflakes
default <- goos == "windows" && `fork/exec .+: The parameter is incorrect\.`

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestAddr2Line
    addr2line_test.go:112: go test -c -o C:\b\s\w\ir\x\t\TestAddr2Line3160068854\001\testaddr2line_test.exe cmd/addr2line: exit status 1
        cmd/vendor/golang.org/x/telemetry/internal/counter: C:\b\s\w\ir\x\w\goroot\pkg\tool\windows_amd64\vet.exe: fork/exec C:\b\s\w\ir\x\w\goroot\pkg\tool\windows_amd64\vet.exe: The parameter is incorrect.
        FAIL
--- FAIL: TestAddr2Line (3.14s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 4, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "cmd/addr2line" && test == "TestAddr2Line"
2025-04-04 17:40 gotip-windows-amd64-race go@6839e71d cmd/addr2line.TestAddr2Line (log)
=== RUN   TestAddr2Line
    addr2line_test.go:112: go test -c -o C:\b\s\w\ir\x\t\TestAddr2Line3160068854\001\testaddr2line_test.exe cmd/addr2line: exit status 1
        cmd/vendor/golang.org/x/telemetry/internal/counter: C:\b\s\w\ir\x\w\goroot\pkg\tool\windows_amd64\vet.exe: fork/exec C:\b\s\w\ir\x\w\goroot\pkg\tool\windows_amd64\vet.exe: The parameter is incorrect.
        FAIL
--- FAIL: TestAddr2Line (3.14s)

watchflakes

@dmitshur dmitshur changed the title cmd/addr2line: TestAddr2Line failures os/exec: ocassional fork/exec failures with "The parameter is incorrect." on Windows Apr 7, 2025
@dmitshur dmitshur moved this to Active in Test Flakes Apr 7, 2025
@dmitshur dmitshur added this to the Go1.25 milestone Apr 7, 2025
@dmitshur dmitshur marked this as a duplicate of #73171 Apr 7, 2025
@dmitshur dmitshur marked this as a duplicate of #73174 Apr 7, 2025
@dmitshur dmitshur marked this as a duplicate of #73175 Apr 7, 2025
@dmitshur dmitshur marked this as a duplicate of #73176 Apr 7, 2025
@dmitshur dmitshur marked this as a duplicate of #73177 Apr 7, 2025
@dmitshur dmitshur marked this as a duplicate of #73178 Apr 7, 2025
@dmitshur dmitshur marked this as a duplicate of #73190 Apr 7, 2025
@dmitshur dmitshur marked this as a duplicate of #73197 Apr 7, 2025
@dmitshur dmitshur marked this as a duplicate of #73198 Apr 7, 2025
@dmitshur dmitshur marked this as a duplicate of #73202 Apr 7, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- goos == "windows" && `fork/exec .+: The parameter is incorrect\.`
2025-04-04 17:53 gotip-windows-amd64-longtest go@5fc596eb runtime:mayMoreStackMove.TestSyscallN/arg-20 (log)
=== RUN   TestSyscallN/arg-20
=== PAUSE TestSyscallN/arg-20
=== CONT  TestSyscallN/arg-20
    syscall_windows_test.go:806: failed to build dll: fork/exec C:\b\s\w\ir\cache\tools\cc\windows\gcc64\bin\gcc.exe: The parameter is incorrect.
--- FAIL: TestSyscallN/arg-20 (0.08s)
2025-04-04 17:53 gotip-windows-amd64-longtest go@5fc596eb runtime:mayMoreStackMove.TestSyscallN/arg-3 (log)
=== RUN   TestSyscallN/arg-3
=== PAUSE TestSyscallN/arg-3
=== CONT  TestSyscallN/arg-3
    syscall_windows_test.go:806: failed to build dll: fork/exec C:\b\s\w\ir\cache\tools\cc\windows\gcc64\bin\gcc.exe: The parameter is incorrect.
--- FAIL: TestSyscallN/arg-3 (0.08s)
2025-04-04 17:53 gotip-windows-amd64-longtest go@5fc596eb runtime:mayMoreStackMove.TestSyscallN/arg-33 (log)
=== RUN   TestSyscallN/arg-33
=== PAUSE TestSyscallN/arg-33
=== CONT  TestSyscallN/arg-33
    syscall_windows_test.go:806: failed to build dll: fork/exec C:\b\s\w\ir\cache\tools\cc\windows\gcc64\bin\gcc.exe: The parameter is incorrect.
--- FAIL: TestSyscallN/arg-33 (0.08s)
2025-04-04 17:53 gotip-windows-amd64-race go@5fc596eb os.TestStartProcess/absolute (log)
=== RUN   TestStartProcess/absolute
=== PAUSE TestStartProcess/absolute
=== CONT  TestStartProcess/absolute
    os_test.go:1218: StartProcess: fork/exec C:\Windows\system32\cmd.exe: The parameter is incorrect.
--- FAIL: TestStartProcess/absolute (0.01s)
2025-04-04 21:00 gotip-windows-amd64-longtest go@7e60bdd7 internal/coverage/cfile.TestIssue59563TruncatedCoverPkgAll (log)
=== RUN   TestIssue59563TruncatedCoverPkgAll
    emitdata_test.go:506: go test -cover failed: exit status 1
        crypto/internal/fips140/aes/gcm: C:\b\s\w\ir\x\w\goroot\pkg\tool\windows_amd64\vet.exe: fork/exec C:\b\s\w\ir\x\w\goroot\pkg\tool\windows_amd64\vet.exe: The parameter is incorrect.
        PASS
        coverage: 8.9% of statements in all
        ok  	internal/coverage/cfile/testdata/issue59563	1.371s
--- FAIL: TestIssue59563TruncatedCoverPkgAll (35.50s)
2025-04-04 22:04 gotip-windows-amd64-race go@2d050e91 net/textproto (log)
FAIL	net/textproto [build failed]
# cmd/cgo/internal/test
# [cmd/cgo/internal/test]
cgo: exec gcc: fork/exec C:\b\s\w\ir\cache\tools\cc\windows\gcc64\bin\gcc.exe: The parameter is incorrect.
2025-04-06 16:36 gotip-windows-amd64 go@6fd9ee3d cmd/vet.TestVet/stdversion (log)
=== RUN   TestVet/stdversion
    vet_test.go:166: error check failed: 
        Unmatched Errors:
        unicode: C:\b\s\w\ir\x\t\go-build15998775\b277\vet.test.exe: fork/exec C:\b\s\w\ir\x\t\go-build15998775\b277\vet.test.exe: The parameter is incorrect.
    vet_test.go:167: vet stderr:
         unicode: C:\b\s\w\ir\x\t\go-build15998775\b277\vet.test.exe: fork/exec C:\b\s\w\ir\x\t\go-build15998775\b277\vet.test.exe: The parameter is incorrect.
        # stdversion
        .\stdversion.go:5:17: reflect.TypeFor requires go1.22 or later (module is go1.21)
        
--- FAIL: TestVet/stdversion (4.54s)
2025-04-07 02:11 gotip-windows-amd64-longtest go@16dbd2be runtime:mayMoreStackMove.TestSyscallN/arg-13 (log)
=== RUN   TestSyscallN/arg-13
=== PAUSE TestSyscallN/arg-13
=== CONT  TestSyscallN/arg-13
    syscall_windows_test.go:806: failed to build dll: fork/exec C:\b\s\w\ir\cache\tools\cc\windows\gcc64\bin\gcc.exe: The parameter is incorrect.
--- FAIL: TestSyscallN/arg-13 (0.08s)
2025-04-07 02:11 gotip-windows-amd64-longtest go@16dbd2be runtime:mayMoreStackMove.TestSyscallN/arg-15 (log)
=== RUN   TestSyscallN/arg-15
=== PAUSE TestSyscallN/arg-15
=== CONT  TestSyscallN/arg-15
    syscall_windows_test.go:806: failed to build dll: fork/exec C:\b\s\w\ir\cache\tools\cc\windows\gcc64\bin\gcc.exe: The parameter is incorrect.
--- FAIL: TestSyscallN/arg-15 (0.09s)
2025-04-07 02:11 gotip-windows-amd64-longtest go@16dbd2be runtime:mayMoreStackMove.TestSyscallN/arg-32 (log)
=== RUN   TestSyscallN/arg-32
=== PAUSE TestSyscallN/arg-32
=== CONT  TestSyscallN/arg-32
    syscall_windows_test.go:806: failed to build dll: fork/exec C:\b\s\w\ir\cache\tools\cc\windows\gcc64\bin\gcc.exe: The parameter is incorrect.
--- FAIL: TestSyscallN/arg-32 (0.10s)
2025-04-07 14:58 gotip-windows-amd64-longtest go@a6e74454 runtime:mayMoreStackMove.TestSyscallN/arg-3 (log)
=== RUN   TestSyscallN/arg-3
=== PAUSE TestSyscallN/arg-3
=== CONT  TestSyscallN/arg-3
    syscall_windows_test.go:806: failed to build dll: fork/exec C:\b\s\w\ir\cache\tools\cc\windows\gcc64\bin\gcc.exe: The parameter is incorrect.
--- FAIL: TestSyscallN/arg-3 (0.20s)
2025-04-07 16:34 gotip-windows-amd64-longtest go@20a924fe runtime:mayMoreStackMove.TestSyscallN/arg-33 (log)
=== RUN   TestSyscallN/arg-33
=== PAUSE TestSyscallN/arg-33
=== CONT  TestSyscallN/arg-33
    syscall_windows_test.go:806: failed to build dll: fork/exec C:\b\s\w\ir\cache\tools\cc\windows\gcc64\bin\gcc.exe: The parameter is incorrect.
--- FAIL: TestSyscallN/arg-33 (0.07s)

watchflakes

@dmitshur
Copy link
Contributor

dmitshur commented Apr 7, 2025

@qmuntal is looking into this. CC @golang/windows.

@dmitshur dmitshur marked this as a duplicate of #73203 Apr 7, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- goos == "windows" && `fork/exec .+: The parameter is incorrect\.`
2025-04-07 20:34 gotip-windows-amd64-longtest go@ffe47d97 internal/coverage/cfile.TestIssue59563TruncatedCoverPkgAll (log)
=== RUN   TestIssue59563TruncatedCoverPkgAll
    emitdata_test.go:506: go test -cover failed: exit status 1
        crypto/internal/fips140only: C:\b\s\w\ir\x\w\goroot\pkg\tool\windows_amd64\vet.exe: fork/exec C:\b\s\w\ir\x\w\goroot\pkg\tool\windows_amd64\vet.exe: The parameter is incorrect.
        PASS
        coverage: 8.9% of statements in all
        ok  	internal/coverage/cfile/testdata/issue59563	0.519s
--- FAIL: TestIssue59563TruncatedCoverPkgAll (25.23s)

watchflakes

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/663715 mentions this issue: syscall: fix dangling pointers in Windows' process attributes

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 8, 2025
@dmitshur dmitshur added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Apr 8, 2025
@github-project-automation github-project-automation bot moved this from Active to Done in Test Flakes Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. OS-Windows release-blocker
Projects
Status: Done
Development

No branches or pull requests

3 participants