Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: change to implement monotonic time in Plan 9 breaks TestFakeTime on plan9 builders #73169

Closed
millerresearch opened this issue Apr 4, 2025 · 1 comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FixPending Issues that have a fix which has not yet been reviewed or submitted. OS-Plan9
Milestone

Comments

@millerresearch
Copy link
Contributor

Following the merge of CL 656755, runtime test always fails on Plan 9 builders:

=== RUN   TestFakeTime
=== PAUSE TestFakeTime
=== CONT  TestFakeTime
    crash_test.go:173: running /home/swarming/.swarming/w/ir/x/w/goroot/bin/go build -o /tmp/go-build1685094314/testfaketime_-tags=faketime.exe -tags=faketime
    time_test.go:32: building testfaketime [-tags=faketime]: exit status: 'go 333592: 1'
        # runtime
        ../../time_fake.go:41:6: time_now redeclared in this block
        	../../os_plan9.go:600:6: other declaration of time_now
        
--- FAIL: TestFakeTime (48.27s)

I believe the problem is that the time_now function in runtime/os_plan9.go needs to be in its own file with a !faketime build tag.

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Apr 4, 2025
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/662856 mentions this issue: runtime: protect plan9 time_now function with !faketime build tag

@dmitshur dmitshur added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Apr 4, 2025
@dmitshur dmitshur added this to the Go1.25 milestone Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FixPending Issues that have a fix which has not yet been reviewed or submitted. OS-Plan9
Projects
None yet
Development

No branches or pull requests

4 participants