x/pkgsite: pkg.go.dev proxy breaks multi-module repositories

[intel352]

What is the URL of the page with the issue?

https://go.dev/doc/modules/managing-source#multiple-module-source

What is your user agent?

n/a

Screenshot

When following the documentation at https://go.dev/doc/modules/managing-source#multiple-module-source, it says that multiple modules can be hosted within a single repository, explicitly using a Version tag format that has a slash.

For example, for module example.com/mymodules/module1 below, you would have the following for version v1.2.3:

Module path: example.com/mymodules/module1
Version tag: module1/v1.2.3
Package path imported by a user: example.com/mymodules/module1/package1
Module path and version as specified in a user’s require directive: example.com/mymodules/module1 v1.2.3

When I attempt to fetch a module in such a way, the go proxy causes go get to fail with an error such as invalid: disallowed version string.

According to #38861, this is a known issue and the guidance is to ditch the proxy and fetch direct.

I'd like to argue that either the proxy itself should be corrected to properly support this documented functionality, or else the documentation itself should be updated to reflect that this is a poorly supported feature and note the workaround that must be utilized to make the feature available.

What did you do?

See above

What did you see happen?

See above

What did you expect to see?

See above

[gabyhelp]

Related Issues

• x/website/_content/doc/modules: invalid require directive example #70747 (closed)
• x/pkgsite: github.com/google/go-tpm-tools not working with pkg.go.dev #52314 (closed)
• cmd/go: rough UX for developing multiple modules in one repository #39993 (closed)
• x/pkgsite: Support pseudoversion semver-timestamp-commit_hash on about pages #59054 (closed)
• proxy.golang.org: problems requesting ssh based git site to pkg.go.dev #59354 (closed)

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[seankhliao]

Nothing is broken, repo tags contain the subdirectory prefix with a slash separating the version.
When requesting the module, the version is just the version number, the prefix is omitted as it's part of the module name.

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.

For questions please refer to https://github.com/golang/go/wiki/Questions