Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestMemoryLimitNoGCPercent failures #73136

Open
gopherbot opened this issue Apr 2, 2025 · 3 comments
Open

runtime: TestMemoryLimitNoGCPercent failures #73136

gopherbot opened this issue Apr 2, 2025 · 3 comments
Assignees
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "runtime" && test == "TestMemoryLimitNoGCPercent"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestMemoryLimitNoGCPercent
    gc_test.go:789: /Users/swarming/.swarming/w/ir/x/t/go-build568260939/testprog.exe GCMemoryLimitNoGCPercent: exit status 2
    gc_test.go:792: expected "OK\n", but got "retained=285218120 limit=268435456 bound=285212672\npanic: exceeded memory limit by more than bound allows\n\ngoroutine 1 [running]:\nmain.gcMemoryLimit(0xffffffffffffffff)\n\t/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/testdata/testprog/gc.go:404 +0x465\nmain.GCMemoryLimitNoGCPercent()\n\t/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/testdata/testprog/gc.go:317 +0x1a\nmain.main()\n\t/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/testdata/testprog/main.go:34 +0x133\n"
--- FAIL: TestMemoryLimitNoGCPercent (3.55s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 2, 2025
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "runtime" && test == "TestMemoryLimitNoGCPercent"
2025-04-01 22:09 gotip-darwin-amd64-longtest go@dceb77a3 runtime.TestMemoryLimitNoGCPercent (log)
=== RUN   TestMemoryLimitNoGCPercent
    gc_test.go:789: /Users/swarming/.swarming/w/ir/x/t/go-build568260939/testprog.exe GCMemoryLimitNoGCPercent: exit status 2
    gc_test.go:792: expected "OK\n", but got "retained=285218120 limit=268435456 bound=285212672\npanic: exceeded memory limit by more than bound allows\n\ngoroutine 1 [running]:\nmain.gcMemoryLimit(0xffffffffffffffff)\n\t/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/testdata/testprog/gc.go:404 +0x465\nmain.GCMemoryLimitNoGCPercent()\n\t/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/testdata/testprog/gc.go:317 +0x1a\nmain.main()\n\t/Users/swarming/.swarming/w/ir/x/w/goroot/src/runtime/testdata/testprog/main.go:34 +0x133\n"
--- FAIL: TestMemoryLimitNoGCPercent (3.55s)

watchflakes

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Apr 2, 2025
@randall77
Copy link
Contributor

This is just over the limit allowed. Maybe we need to loosen the condition a bit?

@mknyszek
Copy link
Contributor

mknyszek commented Apr 9, 2025

The condition is already somewhat loose (a couple percent IIRC). This is in theory always possible since the limit is soft, and the test is really allocating quite quickly. Maybe we retry? IIRC this has happened before, and off the top of my head maybe about once per year. @dmitshur notes that #66893 is the only other instance.

@mknyszek mknyszek self-assigned this Apr 9, 2025
@mknyszek mknyszek added this to the Backlog milestone Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: No status
Development

No branches or pull requests

3 participants