x/text: test results fail to be uploaded to ResultDB

[dmitshur]

The x/text dashboard has turned red:

https://ci.chromium.org/p/golang/g/x-text-gotip-by-go/console

The go test execution itself passes, but LUCI builds (for example, https://ci.chromium.org/b/8719167695879841169) fail with:

Test result for ":golang.org/x/text/message#TestSprintf/%x/��\\x0f�" is invalid: test_id_structured: case_name: unicode replacement character (U+FFFD) at byte index 15
prpc: responding with InvalidArgument error (HTTP 400): test_results[19513]: test_id_structured: case_name: unicode replacement character (U+FFFD) at byte index 15
RPC failed permanently: rpc error: code = InvalidArgument desc = test_results[19513]: test_id_structured: case_name: unicode replacement character (U+FFFD) at byte index 15 {"host":"localhost:44025", "method":"ReportTestResults", "service":"luci.resultsink.v1.Sink"}
 result_adapter: rpc error: code = InvalidArgument desc = test_results[19513]: test_id_structured: case_name: unicode replacement character (U+FFFD) at byte index 15

The test_id_structured field was recently added to result_adapter in crrev.com/c/6395720. This is either a problem on the side of result_adapter and/or ResultDB in that it doesn't handle or escape certain inputs, or, it's possible that the subtest names in the golang.org/x/text/message package are using characters that aren't allowed, and it just happened not to be noticed until now.

CC @golang/release, @mpvl.

[gopherbot]

Change https://go.dev/cl/661495 mentions this issue: message: quote fmt and val in subtest names

[dmitshur]

Fixed via crrev.com/c/6414930, which adds escaping for this character on the side of result_adapter.

Filed #73116 in case there's something the go command can do better in the future.