Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: Root.Open panics when opening a symlink referencing the root [1.24 backport] #73082

Closed
gopherbot opened this issue Mar 28, 2025 · 3 comments
Closed

os: Root.Open panics when opening a symlink referencing the root [1.24 backport] #73082

gopherbot opened this issue Mar 28, 2025 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.24.3

Comments

@gopherbot
Copy link
Contributor

@neild requested issue #73081 to be considered for backport to the next 1.24 minor release.

@gopherbot please backport to Go 1.24. This is a bug with no good workaround.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 28, 2025
@gopherbot gopherbot mentioned this issue Mar 28, 2025
Closed
@gopherbot gopherbot modified the milestones: Go1.24.2, Go1.24.3 Mar 28, 2025
@cagedmantis
Copy link
Contributor

this backport issue has been approved. This is a critical issue without a workaround.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Apr 2, 2025
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 2, 2025
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/662315 mentions this issue: [release-branch.go1.24] os: avoid panic in Root when symlink references the root

gopherbot pushed a commit that referenced this issue Apr 3, 2025
@neild @cagedmantis
[release-branch.go1.24] os: avoid panic in Root when symlink referenc…
fa7217f 
…es the root

We would panic when opening a symlink ending in ..,
where the symlink references the root itself.

For #73081
Fixes #73082

Change-Id: I7dc3f041ca79df7942feec58c197fde6881ecae5
Reviewed-on: https://go-review.googlesource.com/c/go/+/661416
Reviewed-by: Alan Donovan <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
(cherry picked from commit cfc784a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/662315
@gopherbot
Copy link
Contributor Author

Closed by merging CL 662315 (commit fa7217f) to release-branch.go1.24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.24.3
Development

No branches or pull requests
2 participants
@cagedmantis @gopherbot