-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/pkgsite: remove github.com/golang/perf (the correct one is golang.org/x/perf) #68703
Comments
Related Issues and Documentation (Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.) |
CC @aclements maybe? |
https://pkg.go.dev/github.com/golang/perf/cmd/benchstat is the documentation for The psuedoversion cc @golang/pkgsite is there anything we can do here to avoid confusion? Perhaps just remove |
This is probably similar to #68357 (though I didn’t double check the details, so sorry if not). |
When I submitted, it hadn't occurred to me that there were two different URLs for benchstat docs. For My thinking is, if the package crawler detects all of the following:
This manipulation could take the form of a banner I think this approach would work on both #68357 and on this issue. |
golang.org/x/... uses the So while I think your proposed approach would work for most vanity import paths, it wouldn't work here. |
Let's remove github.com/golang/perf from pkgsite. |
Removed |
Go version
N/A
Output of
go env
in your module/workspace:What did you do?
Visit https://pkg.go.dev/github.com/golang/perf/cmd/benchstat
What did you see happen?
Documentation is for
v0.0.0-20190306144031-151b6387e3f2
, from 2019. Documented flags include-html
, which does not exist in the latest version.What did you expect to see?
Documentation matches the binary installed via
go install golang.org/x/perf/cmd/benchstat@latest
.The flag was removed in perf rev 02c5517, from January 2023.
The text was updated successfully, but these errors were encountered: