cmd/link: close file in tempdir so Windows can delete it

neild · gopherbot · commit c6a1dc47297a · 2025-03-31T15:30:17.000-07:00
Fixes #73098 Change-Id: I9f5570903071b15df9e4f8a1820414f305db9d35 Reviewed-on: https://go-review.googlesource.com/c/go/+/661915 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Damien Neil <dneil@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
diff --git a/src/cmd/link/link_test.go b/src/cmd/link/link_test.go
@@ -1564,6 +1564,7 @@ func TestLinknameBSS(t *testing.T) {
 	if err != nil {
 		t.Fatalf("fail to open executable: %v", err)
 	}
+	defer f.Close()
 	syms, err := f.Symbols()
 	if err != nil {
 		t.Fatalf("fail to get symbols: %v", err)

Original file line number	Diff line number	Diff line change
`@@ -1564,6 +1564,7 @@ func TestLinknameBSS(t *testing.T) {`
`1564`	`1564`	`if err != nil {`
`1565`	`1565`	`t.Fatalf("fail to open executable: %v", err)`
`1566`	`1566`	`}`
	`1567`	`+ defer f.Close()`
`1567`	`1568`	`syms, err := f.Symbols()`
`1568`	`1569`	`if err != nil {`
`1569`	`1570`	`t.Fatalf("fail to get symbols: %v", err)`