Skip to content

Commit afab0f4

Browse files
committedMar 13, 2016
Merge pull request #139 from larsxschneider/patch-9
rn-13: add DEVELOPER knob review
2 parents 5cef9ab + d924e4a commit afab0f4

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed
 

‎rev_news/drafts/edition-13.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,21 @@ One nice outcome of this patch series though is that error messages
172172
when there are problems in the config can now tell more precisely
173173
where the problems come from.
174174

175+
* [add DEVELOPER makefile knob to check for acknowledged warnings](http://thread.gmane.org/gmane.comp.version-control.git/287345)
176+
177+
Jeff King noted in a [review](http://thread.gmane.org/gmane.comp.version-control.git/285553/focus=285568)
178+
that *git style doesn't allow declaration-after-statement*. Thereupon
179+
Lars Schneider posted a [patch](http://thread.gmane.org/gmane.comp.version-control.git/285752)
180+
to check for this warning in the TravisCI build. In the review of this
181+
patch Jeff [suggested](http://thread.gmane.org/gmane.comp.version-control.git/285752/focus=285761)
182+
to codify the knowledge about the warnings into an optional Makefile knob
183+
called "DEVELOPER". Lars combined the warnings that [Junio and Jeff](http://thread.gmane.org/gmane.comp.version-control.git/285752/focus=285761) care about and posted a revised version of the [patch](http://thread.gmane.org/gmane.comp.version-control.git/287345).
184+
185+
Git developers with a reasonably modern compiler can now compile Git with
186+
`DEVELOPER=1 make` or set the flag once for all make executions with
187+
`echo DEVELOPER=1 >>config.mak` to ensure their patches are clear of all
188+
compiler warnings that the Git project cares about.
189+
175190
<!---
176191
### Support
177192
-->

0 commit comments

Comments
 (0)