Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add improvements for Godot View Hierarchy #88788

Open
limbonaut opened this issue Apr 4, 2025 · 5 comments
Open

Add improvements for Godot View Hierarchy #88788

limbonaut opened this issue Apr 4, 2025 · 5 comments

Comments

@limbonaut
Copy link

limbonaut commented Apr 4, 2025

I'm working on the Sentry SDK for Godot Engine, and we're adding support for View Hierarchy feature as described in the RFC. You can check it out in the following PR:

We’d like to make some changes to the Sentry UI just for the Godot SDK. Here’s a visual guide:

Image

Requested changes:

  • Change header from "View Hierarchy" to "Scene Tree".
  • Hide or remove the right section since it's not needed for our use-case.
  • Use the name attribute from the JSON attachment for hierarchy item text.
  • Show icon of the Godot Engine on the left side.

Rendering system is specified as Godot in the JSON file. For reference: view-hierarchy.json and issue example.

I kept the JSON attributes named as the properties are named in the Godot Engine (check the links below):

  • name of a scene tree node - it is guaranteed to be unique within the same level of hierarchy
  • class corresponds to the core class of a scene tree node.

If needed, I can rename one or both to identifier and type as suggested in RFC. However, those two would be less recognizable for users.

Here's how it looks in Godot Engine:

Image

cc @bruno-garcia

@getsantry
Copy link
Contributor

getsantry bot commented Apr 4, 2025

Assigning to @getsentry/support for routing ⏲️

@getsantry
Copy link
Contributor

getsantry bot commented Apr 4, 2025

Routing to @getsentry/product-owners-issues for triage ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 3 Apr 4, 2025
@getsantry getsantry bot removed the status in GitHub Issues with 👀 3 Apr 4, 2025
@bruno-garcia bruno-garcia added this to GDX Apr 4, 2025
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Apr 4, 2025
@bruno-garcia
Copy link
Member

@kahest I don't recall but was it your team who added the VH UI? If so wdyt about the changes proposed?

@kahest
Copy link
Member

kahest commented Apr 7, 2025

@bruno-garcia back then we worked with the (now dissolved) MDX team who implemented the product part of it. since you only want to change the presentation for Godot (IIUC), I don't have a strong opinion on this - I realize that a scene tree makes more sense than a view hierarchy. maybe you'd also want to adapt the Unity VH UI?

@bruno-garcia
Copy link
Member

maybe you'd also want to adapt the Unity VH UI?

Talked to Stefan and while "View Hierarchy" isn't ideal, it's fine as it is. They call it just "hierarchy" in Unity.

So this is just about @limbonaut's request for Godot.
I wonder if this is a quick change, @matejminar wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: No status
Development

No branches or pull requests

5 participants