-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add improvements for Godot View Hierarchy #88788
Comments
Assigning to @getsentry/support for routing ⏲️ |
Routing to @getsentry/product-owners-issues for triage ⏲️ |
@kahest I don't recall but was it your team who added the VH UI? If so wdyt about the changes proposed? |
@bruno-garcia back then we worked with the (now dissolved) MDX team who implemented the product part of it. since you only want to change the presentation for Godot (IIUC), I don't have a strong opinion on this - I realize that a scene tree makes more sense than a view hierarchy. maybe you'd also want to adapt the Unity VH UI? |
Talked to Stefan and while "View Hierarchy" isn't ideal, it's fine as it is. They call it just "hierarchy" in Unity. So this is just about @limbonaut's request for Godot. |
I'm working on the Sentry SDK for Godot Engine, and we're adding support for View Hierarchy feature as described in the RFC. You can check it out in the following PR:
We’d like to make some changes to the Sentry UI just for the Godot SDK. Here’s a visual guide:
Requested changes:
name
attribute from the JSON attachment for hierarchy item text.Rendering system is specified as
Godot
in the JSON file. For reference: view-hierarchy.json and issue example.I kept the JSON attributes named as the properties are named in the Godot Engine (check the links below):
name
of a scene tree node - it is guaranteed to be unique within the same level of hierarchyclass
corresponds to the core class of a scene tree node.If needed, I can rename one or both to
identifier
andtype
as suggested in RFC. However, those two would be less recognizable for users.Here's how it looks in Godot Engine:
cc @bruno-garcia
The text was updated successfully, but these errors were encountered: