Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHARTS] Update Frontend Session Health Tab Layout #88237

Closed
3 tasks done
michellewzhang opened this issue Mar 28, 2025 · 2 comments · Fixed by #88502
Closed
3 tasks done

[CHARTS] Update Frontend Session Health Tab Layout #88237

michellewzhang opened this issue Mar 28, 2025 · 2 comments · Fixed by #88502
Assignees
@ryan953 @michellewzhang

Comments

@michellewzhang
Copy link
Member

michellewzhang commented Mar 28, 2025 •
edited
Loading

Image
@vgudur297
Copy link

vgudur297 commented Mar 30, 2025 •
edited
Loading

I am interested in working on this. Please assign it to me
@vgudur297

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Mar 30, 2025
@michellewzhang
Copy link
Member Author

I am interested in working on this. Please assign it to me @vgudur297

Hi @vgudur297! Thank you for your interest :) this ticket is part of an ongoing project being taken care of by the Session Replay team at Sentry, and the scope is bigger (involves making a new component and has a lot of dependencies). It might not be the best ticket to hand off at the current moment.

However, we are always welcoming open source contributions at Sentry -- if you're interested in helping contribute to other easier tasks, please check this link or check all our open issues for other areas where you may be able to contribute! Have a nice day!

@michellewzhang michellewzhang mentioned this issue Apr 3, 2025
Merged
@ryan953 ryan953 closed this as completed in d5c90ad Apr 3, 2025
andrewshie-sentry pushed a commit that referenced this issue Apr 8, 2025
@ryan953 @andrewshie-sentry
feat(insights): Allow picking chart layouts in Insights > Session Hea…
20c9b02 
…lth (#88502)

- Closes #88156
- Closes #88239
- Closes #88237
- Closes #88148

This PR implements a dropdown to replace the standard title within each
chart on the Session Health page. Using the dropdown users can pick
which charts appear in which spots inside the page.

Each page (Frontend, Mobile) has 5 slots (i removed some extra ones)
where charts can go, therefore we need to have at least 6 options in the
dropdown for there to be one 'unused' option that's a valid choice.

Currently the sort-order of the items in the dropdown is alphabetical by
component name (not by the label that appears on the screen). So we need
to revisit that and be intentional about what order we group/suggest
things.

It's all similar but different to how charts were picked, rendered and
saved within the framework of the 'old' insights charts. It should be
extensible to support other types of insights pages and charts. But we
should strive to async load more of the chart types instead of importing
everything into settings.tsx


![SCR-20250403-meod](https://github.com/user-attachments/assets/f5241e69-2884-4bf5-a529-c743b0ea3f1e)

![SCR-20250403-mesp](https://github.com/user-attachments/assets/b0e652ca-60dd-4f35-af4f-fe077444c8e1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryan953 ryan953

@michellewzhang michellewzhang

Labels
None yet
Projects
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(insights): Allow picking chart layouts in Insights > Session Health getsentry/sentry
3 participants
@ryan953 @michellewzhang @vgudur297